-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
data down, actions up #120
Comments
Well, it's a pretty major change that would break every existing use currently, so not so simple to just change it. My loose plan was to do a major refactor at some point to follow DDAU and other changes, but it would be a major version change and obviously not backward compatible. |
@dgavey - this is already implemented so this issue can be closed. |
Current master does not implement DDAU - at least not for all components. E.g. #123 was such a big change that I'm not sure if this case was just missed or if it does not address DDAU at all. In the discussion of that PR closure actions and DDAU was mixed up a lot. I've had a look at the changes in tests and that ones was only about closure actions but not about DDAU. The main point about data down, actions up principle is not to modify any data passed into a component. |
@jelhan - you're right. So this issue remains. |
Any plans to fix this soon? :) I am using a component that its source is a computed.sort property and really could use this. Thanks |
PR's welcome. I'm happy to maintain this project (from a managerial perspective), but I really don't have a lot of extra time to spend on it currently unfortunately. |
ember-drag-drop does not follow data down, actions up (DDAU) pattern yet. It was discussed and future support announced in some issues (#115, #57, #39). How is the status about that one and is there anything blocking that change?
The text was updated successfully, but these errors were encountered: