Rework data logging interfaces #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…log_sync() to base class with custom exception if not subscribable
... without using the WritableDataLogVariable's complicated logic
…w to subclass it Also add explit test for WritableDataLogVariable based log variable
…sive behaviour for end_time
…et_current_view()
mhthies
force-pushed
the
feature/stabilize-data-logging
branch
from
264826f
to
428c2cf
Compare
mhthies
force-pushed
the
feature/stabilize-data-logging
branch
2 times, most recently
from
cda0506
to
d5d9bca
Compare
Any splitting of this method would probably make the code less readable and less performant.
mhthies
force-pushed
the
feature/stabilize-data-logging
branch
from
d5d9bca
to
c244bc9
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #78 +/- ##
==========================================
+ Coverage 81.36% 83.13% +1.76%
==========================================
Files 43 42 -1
Lines 5389 5526 +137
Branches 809 850 +41
==========================================
+ Hits 4385 4594 +209
+ Misses 798 714 -84
- Partials 206 218 +12 ☔ View full report in Codecov by Sentry. |
…c and ChartDataSpec This avoids problems with multiple inheritence (for the 'Generic[T]' typing) with NamedTuple.
mhthies
force-pushed
the
feature/stabilize-data-logging
branch
from
d5f99ab
to
e15b7d6
Compare
... as the test may actually be slowed down by the database operations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
shc.log.generictoshc.data_loggingMove
shc.log.in_memorytoshc.interfaces.in_memory_data_loggingMove
shc.log.mysqltoshc.interfaces.mysqlRename
PersistenceVariabletoDataLogVariableand completely rework internal interface and behaviour.DataLogVariable,LiveDataLogView) from web interface logics (LoggingWebUIView)New test infrastructure for basic unit-testing of all data logging interfaces
Rename
InMemoryPersistenceVariabletoInMemoryDataLogVariableRename
MySQLPersistencetoMySQLConnectorChange interface of
MySQLConnectorfor retrieving non-logging persistence connector objects with new methodpersistence_variable()Tests and documentation for MySQL interface
New database schema for MySQL interface (when used for value persistence without data logging)