added link to github profile to GhUser component; fixed workflow in r…

…eadme
michaelchadwick · Jun 20, 2024 · 5d38cbc · 5d38cbc
1 parent 84d9a20
commit 5d38cbc
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -62,5 +62,6 @@ Currently being built on [Netlify](https://mc-emberjs-remember-stuff.netlify.app
 - Add new serializer fields to `app/serializers/gh-user.js`
   - Use fake data from `public/api/gh-users/michaelchadwick.json`
 - Pass new fields into `<Debug>` component in `app/templates/application.hbs`
-- Add those fields to `<GhUser>` component in `app/components/gh-user.hbs`
+- Add those fields to `<GhUser>` component in `app/components/debug.hbs`
   - (Optional) Add new translations to `/translations/*` files
+- Add those fields to `app/components/gh-user.hbs` template
diff --git a/app/components/debug.hbs b/app/components/debug.hbs
@@ -22,6 +22,7 @@
 
     <GhUser
       @username={{@ghUsername}}
+      @htmlUrl={{@ghHtmlUrl}}
       @publicRepos={{@ghPublicRepos}}
       @publicGists={{@ghPublicGists}}
       @followers={{@ghFollowers}}

diff --git a/app/components/gh-user.hbs b/app/components/gh-user.hbs
@@ -1,7 +1,7 @@
 <div class="gh-user">
   <h3>{{t "components.ghUser.head"}}</h3>
 
-  <strong>{{@username}}</strong><br />
+  <strong><a href={{@htmlUrl}}>{{@username}}</a></strong><br />
   {{t "components.ghUser.repos"}}: {{@publicRepos}}<br />
   {{t "components.ghUser.gists"}}: {{@publicGists}}<br />
   {{t "components.ghUser.followers"}}: {{@followers}}<br />

diff --git a/app/models/gh-user.js b/app/models/gh-user.js
@@ -2,6 +2,7 @@ import Model, { attr } from '@ember-data/model';
 
 export default class GhUserModel extends Model {
   @attr ghUsername;
+  @attr ghHtmlUrl;
   @attr('number') ghPublicRepos;
   @attr('number') ghPublicGists;
   @attr('number') ghFollowers;

diff --git a/app/serializers/gh-user.js b/app/serializers/gh-user.js
@@ -8,6 +8,7 @@ export default class GhUserSerializer extends JSONAPISerializer {
         type: type.modelName,
         attributes: {
           ghUsername: payload.name,
+          ghHtmlUrl: payload.html_url,
           ghPublicRepos: payload.public_repos,
           ghPublicGists: payload.public_gists,
           ghFollowers: payload.followers,

diff --git a/app/templates/application.hbs b/app/templates/application.hbs
@@ -14,6 +14,7 @@
 
   <Debug
     @ghUsername={{@model.ghUsername}}
+    @ghHtmlUrl={{@model.ghHtmlUrl}}
     @ghPublicRepos={{@model.ghPublicRepos}}
     @ghPublicGists={{@model.ghPublicGists}}
     @ghFollowers={{@model.ghFollowers}}