Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor of PACVr.complete; decoding IRCheck as a single variable; handle use of note qualifier for IR name #27

Merged
merged 18 commits into from
Feb 6, 2024

Conversation

alephnull7
Copy link
Collaborator

@alephnull7 alephnull7 commented Feb 5, 2024

In an attempt to reduce the complexity present in PACVr.complete, code responsible for producing an individual variable is present as its own function within PACVr.R. For similar reasons, the bulk of the code for PACVr.verboseInformation has been moved to helpers.R. Related to this goal of better clarity, the parameter of PACVR.complete IRCheck is decoded into a single variable, which can then be passed accordingly and have its elements be accessed as needed.

To address variances in GenBank data, specifically regarding which qualifier is used to detail inverted repeat names, additional checks within checkFeatureQualifiers are performed.

@alephnull7 alephnull7 changed the title Refactor of PACVr.complete & decoding IRCheck as a single variable Refactor of PACVr.complete, decoding IRCheck as a single variable, Feb 5, 2024
@alephnull7 alephnull7 changed the title Refactor of PACVr.complete, decoding IRCheck as a single variable, Refactor of PACVr.complete; decoding IRCheck as a single variable; handle use of note qualifier for IR name Feb 5, 2024
@michaelgruenstaeudl michaelgruenstaeudl merged commit 6efad5c into michaelgruenstaeudl:master Feb 6, 2024
5 checks passed
@michaelgruenstaeudl
Copy link
Owner

michaelgruenstaeudl commented Feb 6, 2024

In an attempt to reduce the complexity present in PACVr.complete, code responsible for producing an individual variable is present as its own function within PACVr.R. For similar reasons, the bulk of the code for PACVr.verboseInformation has been moved to helpers.R. Related to this goal of better clarity, the parameter of PACVR.complete IRCheck is decoded into a single variable, which can then be passed accordingly and have its elements be accessed as needed.

To address variances in GenBank data, specifically regarding which qualifier is used to detail inverted repeat names, additional checks within checkFeatureQualifiers are performed.

Hi Greg,
yes, these are very sensible changes! Great work!

Continuing this goal of providing clarification, can you please rename any variable and function called "verbose" or "verboseInformation()" with "printCovStats()" (or words to that effect), which is what it actually does. Similarly, "writeTables()" should be renamed to "printCovValsAsTable()" (or words to that effect).

Also, it would be fantastic if these coverageStats could be calculated irrespective of analysisSpecs$isIRCheck. After all, the IRCheck only has a relevance for step 3 of verboseInformation() in helpers.R, where writeTables() in its current implementation expects the exact location information of the IRs. What is needed is a second, simpler version of writeTables() that does not operate on the four regions of a quadripartite genome but simply on the entire undivided genome.

Thank you and best, Michael

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants