Ping Pong Delay effect note lag

[michaelkolesidis]

@error-four-o-four

Noticable lag when the effect is enabled and a note is pressed, until the note is heard.

Chrome Version 118.0.5993.89 (Official Build) (64-bit)
Windows 11

[error-four-o-four]

That's a tricky one.

The note lag corresponds to the duration the delay time of the ping pong delay which means that it doesn't play it's source node (the synth). This seems to be the expected behaviour of the effect. One can confirm this by setting the property wet: 0.5.

The expected behaviour before the commit c072ccc was due to the fact that the synth was connected to the destination separately and the effects in a predetermined chain, like

synth --> destination
synth --> ... --> PingPongDelay --> ... -->destination

which means that all effects which were connected after the PingPongDelay did not affect the source. With a setup like
synth --> AutoFilter --> PingPongDelay --> Vibrato one can here that the Vibrato is only applied to the effect of the ping pong delay

Should I recreate this behaviour exactly?

Otherwise I'd suggest to temporary omit the PingPongDelay #44