Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated to Gradle 8.8 #400

Merged

Conversation

ToxicBakery
Copy link
Contributor

  • Updated test suite for 8.7 and 8.8
  • Fixed bugs in configuration
    • Missing settings.gradle causes composite builds to fail
    • GPG signing fails without a key property set
  • Set version to 5.6.1 to reflect minor changes

- Updated test suite for 8.7 and 8.8
- Fixed bugs in configuration
 - Missing settings.gradle causes composite builds to fail
 - GPG signing fails without a key property set
@michel-kraemer
Copy link
Owner

Thanks for your PR! Good work.

Missing settings.gradle causes composite builds to fail

I'm not really sure what you mean here. I cannot reproduce this. Can you please elaborate? Thanks.

GPG signing fails without a key property set

I also cannot reproduce this. Can you tell me, which Gradle command you executed and which error you got?

@ToxicBakery
Copy link
Contributor Author

ToxicBakery commented Jun 26, 2024

Missing settings.gradle causes composite builds to fail

To reproduce this you need to add the project, in my case as a git submodule, to another project and include it in your build as a composite build in the root projects settings.gradle like so:

includeBuild("gradle-download-task")

This results in an error about the build cache if I recall correctly and stems from not having a settings.gradle to isolate the project.

Gradle Composite Builds

We make use of composite builds extensively in our project and from experience, this is atypical to most project setups so I would not expect users attempting to contribute to this project would ever run into this issue.


GPG signing fails without a key property set

This has come up a few times such as Gradle 16597 which partially fixed the problem. Without a signing keyId you receive an error when trying to run publishToMavenLocal even though the the gradle documentation implies you should not. Gradle 5064 has the workaround I included in this PR to check if the keyId is set as part of the onlyIf evaluation.


Can you tell me, which Gradle command you executed and which error you got?

Yes, I apologize for the poorly described PR. I was actually trying to figure out why this plugin is hanging up my projects migration to Kotlin 2.0 (still have not figured that out) and ran into these issues in the process of that effort. I took the Gradle tasks from the workflow file to emulate your validation process.

./gradlew publishToMavenLocal test

I believe the issues encountered came from publishing and not testing which worked without issue for me.

@michel-kraemer
Copy link
Owner

OK. Got it. Thanks for the explanation.

@michel-kraemer michel-kraemer merged commit 65cf851 into michel-kraemer:master Jun 26, 2024
7 checks passed
@ToxicBakery ToxicBakery deleted the feature/gradle-8.8 branch June 26, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants