Fix showing app icon at the start

micheleg · Mar 31, 2021 · 2ee5050 · 2ee5050
1 parent da5bca7
commit 2ee5050
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 6 deletions.
diff --git a/dash.js b/dash.js
@@ -122,6 +122,7 @@ var MyDash = GObject.registerClass({
             vertical: !this._isHorizontal,
             y_expand: this._isHorizontal,
             x_expand: !this._isHorizontal,
+            pack_start: Docking.DockManager.settings.get_boolean('show-apps-at-top')
         });
 
         this._scrollView = new St.ScrollView({
@@ -916,7 +917,7 @@ var MyDash = GObject.registerClass({
     }
 
     /**
-     * Reset the displayed apps icon to mantain the correct order when changing
+     * Reset the displayed apps icon to maintain the correct order when changing
      * show favorites/show running settings
      */
     resetAppIcons() {
@@ -963,7 +964,15 @@ var MyDash = GObject.registerClass({
         this._maxWidth = maxWidth;
         this._maxHeight = maxHeight;
         this._queueRedisplay();
-    }    
+    }
+
+    updateShowAppsButton() {
+        if (Docking.DockManager.settings.get_boolean('show-apps-at-top')) {
+            this._dashContainer.pack_start = true;
+        } else {
+            this._dashContainer.pack_start = false;
+        }
+    }
 });
 
 

diff --git a/docking.js b/docking.js
@@ -466,7 +466,7 @@ var DockedDash = GObject.registerClass({
         ], [
             settings,
             'changed::show-apps-at-top',
-            () => { this.dash.resetAppIcons(); }
+            () => { this.dash.updateShowAppsButton(); }
         ], [
             settings,
             'changed::show-show-apps-button',

diff --git a/schemas/org.gnome.shell.extensions.dash-to-dock.gschema.xml b/schemas/org.gnome.shell.extensions.dash-to-dock.gschema.xml
@@ -47,7 +47,7 @@
   </enum>
   <schema path="/org/gnome/shell/extensions/dash-to-dock/" id="org.gnome.shell.extensions.dash-to-dock">
     <key name="dock-position" enum="org.gnome.shell.extensions.dash-to-dock.position">
-      <default>'LEFT'</default>
+      <default>'BOTTOM'</default>
       <summary>Dock position</summary>
       <description>Dock is shown on the Left, Right, Top or Bottom side of the screen.</description>
     </key>
@@ -233,8 +233,8 @@
     </key>
     <key type="b" name="show-apps-at-top">
       <default>false</default>
-      <summary>Show application button at top</summary>
-      <description>Show application button at top of the dash</description>
+      <summary>Show application button on the left</summary>
+      <description>Show application button on the left of the dash</description>
     </key>
     <key type="b" name="animate-show-apps">
       <default>true</default>