Update for Gnome Shell 46 #2146
Merged
Commits on Mar 18, 2024
-
add_actor() has been removed after being deprecated, and it must be replaced with add_child(). Also, there are two add methods that also have to be changed.
-
Fix hover highlight in Gnome Shell 45
Also remove addActor(), because it was used in a single element.
-
-
There is a property, DockManager.spacing, that isn't defined anywhere, but is used when calling two methods inside (maybeAdjustBoxToDock and maybeAdjustBoxSize). The result is that these methods are being called with an undefined variable, and they use its value to calculate the position of a box, thus resulting in invalid allocation values. This patch fixes this by ensuring that any invalid value in the parameter will be converted to zero. Another possibility would be to fully remove the parameter, since it seems neither to be set the parameter anyhwere, nor to be called those functions from any other place.
-
-
This patch fixes the placement error in the app icons
-
-
-
-
-
windowPreview: Use set_child instead of add_child
While it's safe to use either in GNOME 46, it is not always safe to use (clutter_actor_)add_child directly in GNOME 45. Because the notification StBin requires to update its internal state wasn't added until gnome-shell@ed3b8d093e introduced in 46.alpha. At least (st_bin_)set_child remains the same in all GNOME versions, and is what the old (clutter_container_)add_actor used to call in GNOME 45. There may be other places where we need to change add_child to set_child for backward compatibility with StBin, but if they exist then they're not causing problems yet. Closes: https://bugs.launchpad.net/bugs/2056506 Fixes: 4945dbf
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.