Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Gnome Shell 46 #2146

Merged
merged 12 commits into from
Mar 20, 2024

Commits on Mar 18, 2024

  1. Update for Gnome Shell 46

    add_actor() has been removed after being deprecated, and it must
    be replaced with add_child(). Also, there are two add methods
    that also have to be changed.
    sergio-costas committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    da38b12 View commit details
    Browse the repository at this point in the history
  2. Fix hover highlight in Gnome Shell 45

    Also remove addActor(), because it was used in a single element.
    sergio-costas committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    9b037f8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6a657eb View commit details
    Browse the repository at this point in the history
  4. Fix Overview mode

    There is a property, DockManager.spacing, that isn't defined
    anywhere, but is used when calling two methods inside
    (maybeAdjustBoxToDock and maybeAdjustBoxSize). The result is
    that these methods are being called with an undefined variable,
    and they use its value to calculate the position of a box, thus
    resulting in invalid allocation values.
    
    This patch fixes this by ensuring that any invalid value in
    the parameter will be converted to zero.
    
    Another possibility would be to fully remove the parameter,
    since it seems neither to be set the parameter anyhwere, nor to
    be called those functions from any other place.
    sergio-costas committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    aadd53b View commit details
    Browse the repository at this point in the history
  5. Code simplification

    sergio-costas committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    e4a84f2 View commit details
    Browse the repository at this point in the history
  6. Fix position error

    This patch fixes the placement error in the app icons
    sergio-costas committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    4191811 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    68e0203 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    de35ab6 View commit details
    Browse the repository at this point in the history
  9. Nitpicks requested

    sergio-costas committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    5f6d27c View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    3759956 View commit details
    Browse the repository at this point in the history
  11. windowPreview: Use set_child instead of add_child

    While it's safe to use either in GNOME 46, it is not always safe to use
    (clutter_actor_)add_child directly in GNOME 45. Because the notification
    StBin requires to update its internal state wasn't added until
    gnome-shell@ed3b8d093e introduced in 46.alpha.
    
    At least (st_bin_)set_child remains the same in all GNOME versions, and
    is what the old (clutter_container_)add_actor used to call in GNOME 45.
    
    There may be other places where we need to change add_child to set_child
    for backward compatibility with StBin, but if they exist then they're not
    causing problems yet.
    
    Closes: https://bugs.launchpad.net/bugs/2056506
    Fixes: 4945dbf
    vanvugt authored and sergio-costas committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    42ee745 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    8349757 View commit details
    Browse the repository at this point in the history