Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dot height in default mode #2168

Merged

Conversation

sergio-costas
Copy link
Collaborator

Fix #2160

@sergio-costas
Copy link
Collaborator Author

@vanvugt Fixed the dot height in Gnome 46, and confirmed that it doesn't break in Gnome 45.

@vanvugt
Copy link
Collaborator

vanvugt commented Mar 25, 2024

Thanks. Testing it I see the dot is still too close to the icon. And reverting to scale 100% doesn't totally fix that.

Can you check to see how upstream does their spacing?

@vanvugt
Copy link
Collaborator

vanvugt commented Mar 25, 2024

Maybe fixing #2173 would change things? Or maybe it's not related.

@sergio-costas
Copy link
Collaborator Author

I see the dot exactly in the same place than in gnome 45...

Gnome45:
Captura desde 2024-03-25 16-55-50

Gnome46:
imagen

@sergio-costas
Copy link
Collaborator Author

But, of course, I don't use scaling... At which scale are you using your desktop? How can I take into account scaling in CSS?

@3v1n0
Copy link
Collaborator

3v1n0 commented Mar 25, 2024

How can I take into account scaling in CSS?

Css should handle it automatically.

You can simulate scaling in a nested GNOME shell easily though. Launches it with something like MUTTER_DEBUG_DUMMY_MONITOR_SCALES=1 and MUTTER_DEBUG_DUMMY_MODE_SPECS="1920x1080:3840x2160:4096x2160:7680x4320:3840x2400:3200x1800:2650x1440:1024x768:800x600:1440x900:1680x1050:1680x1012"

@vanvugt
Copy link
Collaborator

vanvugt commented Mar 26, 2024

I see the dot exactly in the same place than in gnome 45...

Gnome45: Captura desde 2024-03-25 16-55-50

Gnome46: imagen

That's not a good example because they are different icons (one's not square). Also the dot is touching the bottom in the second screenshot, but not the first. But all this may be off-topic so I'll take new screenshots...

@vanvugt
Copy link
Collaborator

vanvugt commented Mar 26, 2024

OK my main concern is only visible at 200% today:

gnome-shell #2168
scale200-gnome-shell scale200-pr2168

_stylesheet.scss Outdated Show resolved Hide resolved
@vanvugt vanvugt force-pushed the fix-dot-height-in-default-mode branch from 298fc14 to 33427bb Compare March 27, 2024 05:47
@vanvugt vanvugt merged commit 1053b3e into micheleg:master Mar 27, 2024
1 check passed
vanvugt pushed a commit that referenced this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dot indicators appear on top of icons in GNOME 46
3 participants