Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

locations: Do not cancel operations after a volume has been umounted / removed #2200

Merged
merged 2 commits into from
Apr 19, 2024
Merged

locations: Do not cancel operations after a volume has been umounted / removed #2200

merged 2 commits into from
Apr 19, 2024

Commits on Apr 18, 2024

  1. locations: Do not cancel operations after a volume has been umounted … 

    …/ removed

In case we're unmounting a volume we were optionally removing its icon
but this was also leading cancelling the operation that in the Gio queue
caused the action not to be fully performed.

So once, we've removed a volume or umounted a mount, we don't really
care about cancelling the ongoing operations since they should be done
already.

LP: #1993054
    @3v1n0
    3v1n0 committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    32acbd3 View commit details
    Browse the repository at this point in the history

  2. locations: Do not warn if a file info has not the icon attribute 

    We were still getting a null icon but Gio was warning about so we
can just check if it has such attribute first.
    @3v1n0
    3v1n0 committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    ff71f29 View commit details
    Browse the repository at this point in the history