Icon indicators everywhere #2267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid keeping track of source twice, and cleanup the usage of it when we only rely on the related app.
This changed as part of upstream commit: https://gitlab.gnome.org/GNOME/gnome-shell/-/commit/745667a825
This doesn't happen upstream, so let's handle it ourselves
Use the very same wording for both the dock icons and the overview icons so that both match. This implies breaking the translations but we're fine at this point. Probably better not to use the old "favorites" naming yet.
It's more integrated and uses less space
This is the UI class, while the appIcons one is only supposed to be a model class
These properties may have been set already by any application around (hey snapd!), so we need to initialize the values properly and not only rely on updates. So that when application is launched we pick those values
If unity indicators are enabled we should show them allover the places, but we didn't so far, so let's add support for patching all the kinds of icons so that we can define the behavior when this happens
And use it to move the progressbar next to the middle of an icon if it includes a label
Do not allow performing any action on updating apps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shows Unity Icons indicators everywhere (overview, search results...) when they are enabled.
Handles updating applications better when in they're not pinned to the dock.