Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Animate Show Applications from the desktop (Fix "Show Applications" button) #2275

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

sergio-costas
Copy link
Collaborator

@sergio-costas sergio-costas commented Aug 28, 2024

The "Show Applications" button fails because the Overview.ANIMATION_TIME property is now read-only (it has a "const" prefix), so it's not possible to overwrite it to show the applications list "instantaneously". It "does nothing" and shows this error in the log:

ago 28 12:20:46 raster3-PROX14-AMD gnome-shell[534248]: JS ERROR: TypeError: "ANIMATION_TIME" is read-only
                                                        _onShowAppsButtonToggled/<@file:///home/raster/.local/share/gnome-shell/extensions/dash-to-dock@micxgx.gmail.com/docking.js:2491:21
                                                        @resource:///org/gnome/shell/ui/init.js:21:20

This patch removes the option of disabling the animation, thus fixing the problem.

@3v1n0
Copy link
Collaborator

3v1n0 commented Aug 28, 2024

I think it's fine to drop this option, since it was mostly something problematic in the past, HOWEVER... Not sure if some user rely on that (but I guess no because we had no many complaints)

In case we want to keep the option, we could technically just patch Overview.animateToOverview and panel.fadeIn on click to not animate, but this looks still prone to breakage, so I think we're good dropping it.

@3v1n0
Copy link
Collaborator

3v1n0 commented Aug 28, 2024

Please, just squash your commits in one

@3v1n0 3v1n0 changed the title Fix "Show Applications" button Remove Animate Show Applications from the desktop (Fix "Show Applications" button) Aug 28, 2024
The "Show Applications" button fails because the
Overview.ANIMATION_TIME property is now read-only (it has a
"const" prefix), so it's not possible to overwrite it to show
the applications list "instantaneously".

This patch removes the option of disabling the animation, thus
fixing the problem.
@sergio-costas
Copy link
Collaborator Author

@3v1n0 Squashed.

@3v1n0 3v1n0 merged commit 6ab2267 into micheleg:master Aug 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants