Style focused overview-icon backgrounds only for built-in theme #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Focused application's icon was highlighted with light background in stylesheet.css when using custom window counter indicators, or dash-to-dock's built-in theme. Since that highlight style isn't necessarily visible, or simply doesn't look good with some gnome-shell themes, it seems better to style the background only when using the built-in theme, and use default focused styling from the shell theme otherwise. For that reason, stop styling the focused icon when using custom indicators.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Focused application's icon is highlighted with light background in stylesheet.css when using custom window counter indicators, or dash-to-dock's built-in theme.
Since that highlight style isn't necessarily visible (if the dock has light background), or simply doesn't look good with some gnome-shell themes, it seems better to style the background only when using the built-in theme, and use default focused styling from the shell theme otherwise.
In addition to the above, the setting label "Customize window counter indicators" implies that it would only have effect on the running dots, and leave any other styling as it is.
This PR removes the focused icon highlight when using custom running dots, and it is only applied for the built-in theme.