Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added features described in Django 2.2 docs #204

Open
wants to merge 2 commits into
base: azure-2.1
Choose a base branch
from

Conversation

JordanReiter
Copy link

As far as I can tell these are all the features needed for Django 2.2 compatibility. I think technically SQL Server could support partial indexes but for now it can just be unsupported.

@morlandi
Copy link

morlandi commented Apr 23, 2019

Many thanks @JordanReiter
Works as expected ... +1 to merge into main branch

@JordanReiter
Copy link
Author

@morlandi no problem! I do think it means that some functionality that could potentially be supported is missing, but at the very least it works and provides similar functionality that was present in version 2.1.

@morlandi
Copy link

morlandi commented Apr 26, 2019

at the very least it works and provides similar functionality that was present in version 2.1.

True

I just wonder: isn't the package too restrictive in raising an exception when the actual Django version is ABOVE the expected one ? In my opinion, a warning would be more appropriate.

I just migrated to Django 2.2 a reasonably complex project requiring 60 external Python modules / apps. In doing so, I took the responsibility to supervise the process and check all unit tests.
All in all, that wasn't too bad.
And guess what ? ... the only nuisance was related to django-pyodbc-azure and it's restrictive setup constraints. Would all other involved Django apps be so restrictive, I couldn't have possibly dealt with this migration at all.

@JordanReiter
Copy link
Author

JordanReiter commented Apr 26, 2019 via email

@morlandi
Copy link

Hmmm ... I totally agree on the "better safe than sorry" approach ;)

On the other side, If you compare the file changes between subsequent versions of the package, you'll mainly find extensions and optimisations, more than fixes for incompatibility issues.
That is probably because the Django ORM is consolidated enough to require very infrequent backward-incompatible changes in this area.

While I'm at it, let me thank you again for contribution, and a big big thank to @michiya for his remarkable commitment

@peterfarrell
Copy link

We are using the code in the PR and it works as expected. +1 on getting this merged in ASAP.

@yrchen yrchen mentioned this pull request Jun 11, 2019
@Crocmagnon
Copy link

What is the status of this PR ? Django 2.0 has been out since 3 months now, this lib is the only one forcing us to stay on 2.1 😕

@@ -26,7 +26,7 @@
license='BSD',
packages=['sql_server', 'sql_server.pyodbc'],
install_requires=[
'Django>=2.1.0,<2.2',
'Django>=2.2.0,<2.3',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for the record, there will be no Django 2.3. The next release is 3.0 😊
See : https://docs.djangoproject.com/en/dev/internals/release-process/ and https://www.djangoproject.com/download/

@twisbrogan
Copy link

Working as expected here. All for getting in merged in.

@frafra
Copy link

frafra commented Jul 26, 2019

README.md should be updated too ;-) Thank you for your efforts!

@GlamTam
Copy link

GlamTam commented Nov 28, 2019

Works as expected ... +1 to merge into main branch

@kummerer94
Copy link

Works for us, too.

@sgupta227
Copy link

Please merge it to master.

@JordanReiter
Copy link
Author

Please merge it to master.

Would if I could buddy.

@daybarr
Copy link

daybarr commented Dec 9, 2019

For those asking for this PR to be merged, it looks like @michiya has had to move on after giving much hard work on this project. We thank him for his efforts and outstanding contribution over the years.

For the future, @FlipperPA has kicked off a project to incorporate this work into the core of the Django project itself

While that work continues, the 2019-12-04 update from FlipperPA endorses the https://github.com/ESSolutions/django-mssql-backend fork of this repo:

We are still waiting for a reply from Microsoft. They're a large company, so understandably, it takes a little while.

For now, if people need to get onto Django 2.2 for long term support (which will last until April, 2022), you can use this package:

https://github.com/ESSolutions/django-mssql-backend

If Microsoft and/or the Django Software Foundation end up wanting to bring support for SQL Server into core, the django-mssql-backend repository is a possible starting point, IMHO.

https://github.com/ESSolutions/django-mssql-backend has merged Django 2.2 compatibility into master, as well as various other fixes. @OskarPersson is working hard on Django 3 support too (ESSolutions#18). We should probably all switch to using django-mssql-backend, instead of django-pyodbc-azure, and thank @OskarPersson for picking up the baton that @michiya ran with for so long.

@wdifruscio
Copy link

HI everyone! This looks awesome and I am ready to try it out :D, however I am wondering has anyone tried django 3.0 yet? I am kicking off a new service soon and would love to use the newest version but I am a little concerned about the connection to mssql - thoughts? Is anything radically different in 3.0?

@OskarPersson
Copy link

@wdifruscio See ESSolutions#19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.