Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added features described in Django 2.2 docs #204

Open
wants to merge 2 commits into
base: azure-2.1
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

setup(
name='django-pyodbc-azure',
version='2.1.0.0',
version='2.2.0.0',
description='Django backend for Microsoft SQL Server and Azure SQL Database using pyodbc',
long_description=open('README.rst').read(),
author='Michiya Takahashi',
Expand All @@ -26,7 +26,7 @@
license='BSD',
packages=['sql_server', 'sql_server.pyodbc'],
install_requires=[
'Django>=2.1.0,<2.2',
'Django>=2.2.0,<2.3',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for the record, there will be no Django 2.3. The next release is 3.0 😊
See : https://docs.djangoproject.com/en/dev/internals/release-process/ and https://www.djangoproject.com/download/

'pyodbc>=3.0',
],
classifiers=CLASSIFIERS,
Expand Down
2 changes: 1 addition & 1 deletion sql_server/pyodbc/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
from django.core.exceptions import ImproperlyConfigured
from django import VERSION

if VERSION[:3] < (2,1,0) or VERSION[:2] >= (2,2):
if VERSION[:3] < (2,2,0) or VERSION[:2] >= (2,3):
raise ImproperlyConfigured("Django %d.%d.%d is not supported." % VERSION[:3])

try:
Expand Down
4 changes: 4 additions & 0 deletions sql_server/pyodbc/features.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
class DatabaseFeatures(BaseDatabaseFeatures):
allow_sliced_subqueries_with_in = False
can_introspect_autofield = True
can_introspect_duration_field = False
can_introspect_small_integer_field = True
can_return_id_from_insert = True
can_use_chunked_reads = False
Expand All @@ -18,13 +19,16 @@ class DatabaseFeatures(BaseDatabaseFeatures):
ignores_quoted_identifier_case = True
requires_literal_defaults = True
requires_sqlparse_for_splitting = False
supports_ignore_conflicts = False
supports_index_on_text_field = False
supports_nullable_unique_constraints = False
supports_paramstyle_pyformat = False
supports_partially_nullable_unique_constraints = False
supports_partial_indexes = True
supports_regex_backreferencing = False
supports_sequence_reset = False
supports_subqueries_in_group_by = False
supports_table_check_constraints = True
supports_tablespaces = True
supports_temporal_subtraction = True
supports_timezones = False
Expand Down