Add compatibility for SQL Server 2019 v15 #213
Conversation
The code works fine as is with v15, however connection fails as the key is missing from _sql_server_versions. Adding the key resolves this issue.
| @@ -157,6 +157,7 @@ class DatabaseWrapper(BaseDatabaseWrapper): | |||
| 12: 2014, | |||
| 13: 2016, | |||
| 14: 2017, | |||
| 15: 2017, | |||
There was a problem hiding this comment.
Should be
15: 2019,2019 not 2017 ;)
But ... this project is no longer being maintained, and you should probably consider switching to https://github.com/FlipperPA/django-mssql-backend which has forked this project, landed the recent suggested improvements here, and is working to get mssql support into Django core. I've ported your PR over to that project (which also needs the change) in FlipperPA/django#13 . Thanks
There was a problem hiding this comment.
Ah sorry, I got confused. As noted here FlipperPA has actually endorsed the https://github.com/ESSolutions/django-mssql-backend fork which is putting out packages and supports Django 3 now.
I've ported your PR over to that project instead, which is what I should have done in the first place sorry. ESSolutions#32
The code works fine as is with v15, however connection fails as the key is missing from _sql_server_versions. Adding the key resolves this issue.