Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make relative URLs in e- properties absolute #201

Merged
merged 7 commits into from
Nov 30, 2023

Conversation

angelogladding
Copy link
Collaborator

@angelogladding angelogladding commented Jul 6, 2023

Closes #181.

Does not support srcset -- should eventually reuse logic from #188 when ready.

@capjamesg
Copy link
Member

@angelogladding Is this PR ready for a review? If so, please mark me as a reviewer.

@angelogladding
Copy link
Collaborator Author

angelogladding commented Oct 16, 2023

srcset can be added along with #188. Inclusion of the others listed in #181 (comment) can be debated and added at a later date.

Copy link
Member

@capjamesg capjamesg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@snarfed
Copy link
Member

snarfed commented Nov 29, 2023

Really excited for this. Looks like it's ready to merge? I'd dearly love for it to go into 2.0!

@angelogladding angelogladding merged commit a0edfdb into main Nov 30, 2023
15 checks passed
@angelogladding angelogladding deleted the handle-relative-urls-in-e branch November 30, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve relative URLs in e-* HTML content
3 participants