Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add language support #203

Closed
wants to merge 5 commits into from
Closed

Add language support #203

wants to merge 5 commits into from

Conversation

angelogladding
Copy link
Collaborator

Add language details to embedded properties and root microformats using the following order of specificity:

  • embedded properties (class=e-* lang=..)
  • root microformats (class=h-* lang=..)
  • document root (<html lang=..>)

Closes #150.

@capjamesg capjamesg self-requested a review October 14, 2023 07:38
Copy link
Member

@snarfed snarfed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you! This lgtm, and I appreciate the tests, but I don't actually know this codebase, so I defer to @capjamesg @sknebel @gRegorLove @kevinmarks et al.

Copy link
Member

@capjamesg capjamesg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! This is a concise, elegant implementation. We may want another review from someone familiar with the codebase per @snarfed's comment.

@angelogladding angelogladding closed this by deleting the head repository Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support lang attribute for language
3 participants