Webview: Fix the exception after multi-process access #2684
+92
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mar-v-in
reviewed
Dec 13, 2024
There was a problem hiding this comment.
I guess the issue stems from ReCaptchaOverlay running on the main process instead of the :ui process because it is part of FirebaseAuthService. The solution should be to have ReCaptchaOverlay use its own, separate service, that then can reside on the :ui process.
Processed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
12-13 15:35:42.347 4474 4474 E AndroidRuntime: FATAL EXCEPTION: main
12-13 15:35:42.347 4474 4474 E AndroidRuntime: Process: com.google.android.gms:ui, PID: 4474
12-13 15:35:42.347 4474 4474 E AndroidRuntime: java.lang.RuntimeException: Unable to start activity ComponentInfo{com.google.android.gms/org.microg.gms.auth.login.LoginActivity}: java.lang.RuntimeException: Using WebView from more than one process at once with the same data directory is not supported. https://crbug.com/558377 : Current process com.google.android.gms:ui (pid 4474), lock owner com.google.android.gms (pid 5405)
12-13 15:35:42.347 4474 4474 E AndroidRuntime: at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:4841)
12-13 15:35:42.347 4474 4474 E AndroidRuntime: at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:5059)
12-13 15:35:42.347 4474 4474 E AndroidRuntime: at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:123)
12-13 15:35:42.347 4474 4474 E AndroidRuntime: at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:149)
12-13 15:35:42.347 4474 4474 E AndroidRuntime: at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:103)
12-13 15:35:42.347 4474 4474 E AndroidRuntime: at android.app.ActivityThread$H.handleMessage(ActivityThread.java:3131)
12-13 15:35:42.347 4474 4474 E AndroidRuntime: at android.os.Handler.dispatchMessage(Handler.java:117)
12-13 15:35:42.347 4474 4474 E AndroidRuntime: at android.os.Looper.loopOnce(Looper.java:205)
12-13 15:35:42.347 4474 4474 E AndroidRuntime: at android.os.Looper.loop(Looper.java:293)
12-13 15:35:42.347 4474 4474 E AndroidRuntime: at android.app.ActivityThread.loopProcess(ActivityThread.java:10062)
12-13 15:35:42.347 4474 4474 E AndroidRuntime: at android.app.ActivityThread.main(ActivityThread.java:10051)
12-13 15:35:42.347 4474 4474 E AndroidRuntime: at java.lang.reflect.Method.invoke(Native Method)
12-13 15:35:42.347 4474 4474 E AndroidRuntime: at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:593)
12-13 15:35:42.347 4474 4474 E AndroidRuntime: at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1245)
12-13 15:35:42.347 4474 4474 E AndroidRuntime: Caused by: java.lang.RuntimeException: Using WebView from more than one process at once with the same data directory is not supported. https://crbug.com/558377 : Current process com.google.android.gms:ui (pid 4474), lock owner com.google.android.gms (pid 5405)
12-13 15:35:42.347 4474 4474 E AndroidRuntime: at org.chromium.android_webview.AwDataDirLock.b(HwWebview-15.0.3.333.21001:182)
12-13 15:35:42.347 4474 4474 E AndroidRuntime: at org.chromium.android_webview.AwBrowserProcess.k(HwWebview-15.0.3.333.21001:15)
12-13 15:35:42.347 4474 4474 E AndroidRuntime: at com.android.webview.chromium.M.e(HwWebview-15.0.3.333.21001:147)
12-13 15:35:42.347 4474 4474 E AndroidRuntime: at com.android.webview.chromium.M.b(HwWebview-15.0.3.333.21001:42)
12-13 15:35:42.347 4474 4474 E AndroidRuntime: at com.android.webview.chromium.WebViewChromiumFactoryProvider.k(HwWebview-15.0.3.333.21001:11)
12-13 15:35:42.347 4474 4474 E AndroidRuntime: at com.android.webview.chromium.WebViewChromium.init(HwWebview-15.0.3.333.21001:102)
12-13 15:35:42.347 4474 4474 E AndroidRuntime: at android.webkit.WebView.(WebView.java:472)
12-13 15:35:42.347 4474 4474 E AndroidRuntime: at android.webkit.WebView.(WebView.java:390)
12-13 15:35:42.347 4474 4474 E AndroidRuntime: at android.webkit.WebView.(WebView.java:372)
12-13 15:35:42.347 4474 4474 E AndroidRuntime: at android.webkit.WebView.(WebView.java:359)
12-13 15:35:42.347 4474 4474 E AndroidRuntime: at android.webkit.WebView.(WebView.java:349)
12-13 15:35:42.347 4474 4474 E AndroidRuntime: at org.microg.gms.auth.login.LoginActivity.createWebView(LoginActivity.java:226)
12-13 15:35:42.347 4474 4474 E AndroidRuntime: at org.microg.gms.auth.login.LoginActivity.onCreate(LoginActivity.java:117)
12-13 15:35:42.347 4474 4474 E AndroidRuntime: at android.app.Activity.performCreate(Activity.java:8582)
12-13 15:35:42.347 4474 4474 E AndroidRuntime: at android.app.Activity.performCreate(Activity.java:8555)
12-13 15:35:42.347 4474 4474 E AndroidRuntime: at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1344)
12-13 15:35:42.347 4474 4474 E AndroidRuntime: at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:4809)
12-13 15:35:42.347 4474 4474 E AndroidRuntime: ... 13 more