Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt Stable OTEL Semantic Conventions for JVM metrics #5286

Open
lenin-jaganathan opened this issue Jul 4, 2024 · 4 comments
Open

Adopt Stable OTEL Semantic Conventions for JVM metrics #5286

lenin-jaganathan opened this issue Jul 4, 2024 · 4 comments

Comments

@lenin-jaganathan
Copy link
Contributor

Please describe the feature request.
In open-telemetry/semantic-conventions#569, OpenTelemetry has made JVM metrics stable. It makes sense to adopt the stable semantic convention for OTLPMeterRegistry to keep in line with the OTEL Semantic Convention.

Additional context
Related links,

@shakuzen
Copy link
Member

shakuzen commented Jul 4, 2024

Since in Micrometer we consider changing existing meter names and tags a breaking change, I'm not sure how we would do this outside a new major version. Any ideas?

It makes sense to adopt the stable semantic convention for OTLPMeterRegistry to keep in line with the OTEL Semantic Convention.

I also wouldn't tie a wire format (OTLP) to a semantic convention - I think they should be separate decisions. It should be valid to use OpenTelemetry semantic conventions with a format other than OTLP and it should be valid to use OTLP without using the OpenTelemetry semantic conventions.

@ntkoopman
Copy link

Add additional OTEL specific MeterBinder implementations in addition to the JVM ones?
Or add an option to the current ones to output the updated OTEL conventions and leave it to the user to set it?

@lenin-jaganathan
Copy link
Contributor Author

I am working on something within our organization. It is a bit of hybrid approach with using MeterFilter for renaming existing things and an additional MeterBinder for missing pieces. I can create a follow-up PR if we agree on the approach in this issue.

Yeah, this should be a opt-in thing for the reason @shakuzen mentioned above.

@jonatan-ivanov
Copy link
Member

As an alternative to the MeterFilter, I think using a mechanism that is somewhat similar to ObservationConvention might work too but's that is a bigger change and it includes new public API components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants