Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zgcGenerationalTest is flaky on CI #5296

Open
shakuzen opened this issue Jul 10, 2024 · 0 comments
Open

zgcGenerationalTest is flaky on CI #5296

shakuzen opened this issue Jul 10, 2024 · 0 comments
Labels
help wanted An issue that a contributor can help us with type: task A general task
Milestone

Comments

@shakuzen
Copy link
Member

See, for example, https://app.circleci.com/pipelines/github/micrometer-metrics/micrometer/6982/workflows/66800576-a887-4030-b36a-5068d498950b/jobs/35044. JvmGcMetricsTest > gcTimingIsCorrectForPauseCycleCollectors() fails fairly often when running the zgcGenerationalTest task during the CI build. Unfortunately I think it's a matter of whether a GC happens during the test code running that is collecting numbers to make assertions about the metrics having the right numbers for GCs. I don't have a great idea how to improve this.

> Task :micrometer-core:zgcGenerationalTest

JvmGcMetricsTest > gcTimingIsCorrectForPauseCycleCollectors() FAILED
    org.opentest4j.AssertionFailedError: 
    expected: 11L
     but was: 10L
        at app//io.micrometer.core.instrument.binder.jvm.JvmGcMetricsTest.lambda$checkPhaseCount$3(JvmGcMetricsTest.java:236)
@shakuzen shakuzen added help wanted An issue that a contributor can help us with type: task A general task labels Jul 10, 2024
@shakuzen shakuzen added this to the 1.12.x milestone Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted An issue that a contributor can help us with type: task A general task
Projects
None yet
Development

No branches or pull requests

1 participant