Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review this plugin for addition to OME org and Docker images #1

Open
manics opened this issue Sep 30, 2020 · 2 comments
Open

Review this plugin for addition to OME org and Docker images #1

manics opened this issue Sep 30, 2020 · 2 comments

Comments

@manics
Copy link
Contributor

manics commented Sep 30, 2020

The first feature is is currently done in the Docker images so should be uncontroversial. As for the others? Using YAML for OMERO.web configuration is a lot easier than a single line of dense JSON, but it's a new feature.

  • Read config properties from CONFIG_omero.... environment variables.
  • Read configuration from YAML/JSON: Years ago someone asked whether you could configure something like Mapr from the IDR's ansible configuration variables. Now you almost can with a bit of editting.
  • Convert Jinja2 to YAML/JSON: Many of the IDR Ansible variables contain Jinja2 statements. If they are of the form {{ variable | default('x') }} this can be handled by Jinja2 since default is a built-in filter. This gets us even closer to being able to use the ansible configuration with few changes.
@joshmoore
Copy link
Member

joshmoore commented Dec 12, 2020

My first repo review:

  1. From the README, it's unclear how server_set is picked up as oposed to web_set, for example.

  2. Does https://github.com/manics/omero-cli-externalconfig/blob/main/.github/workflows/workflow.yml need unification with any of the templates?

  3. .travis.yml can be deleted.

  4. What would be the first non-docker target for use?

@manics manics mentioned this issue Jan 19, 2021
@manics
Copy link
Contributor Author

manics commented Jan 19, 2021

  1. Updated
  2. See Switch to tox #2 though it's not currently passing
  3. Deleted
  4. Not sure, it's probably more useful to allow Docker to use the Ansible config than the other way around

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants