Skip to content

Commit

Permalink
- Rename package name to test npm publish
Browse files Browse the repository at this point in the history
  • Loading branch information
Franck Cornu committed Nov 27, 2023
1 parent acf1658 commit 5c6da1a
Show file tree
Hide file tree
Showing 36 changed files with 3,045 additions and 2,897 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/deploy-docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ jobs:
run: pnpm install

- name: Build Storybook
run: npx lerna run docs:build --scope=@pnp/modern-search-core
run: npx lerna run docs:build --scope=pnp-modern-search-core

- name: Run PowerShell deployment
shell: pwsh
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/publish.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Publish Modern Search Core Components library
name: Deploy Modern Search Core Components - NPM Publish

on:
push:
Expand Down Expand Up @@ -83,6 +83,9 @@ jobs:
- name: Version package
run: pnpm version $VERSION --no-git-tag-version

- name: Bunde
run: pnpm run bundle:prod

- name: Build
run: pnpm run build

Expand Down
4 changes: 2 additions & 2 deletions docs/development/concepts/deployment.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ All script parameters are managed trhough a PowerShell script with the following

To deploy from your local machine:

1. From the solution root folder, run `npx lerna run bundle:prod --scope=@pnp/modern-search-core`. This will bundle the components in production mode.
1. From the solution root folder, run `npx lerna run bundle:prod --scope=pnp-modern-search-core`. This will bundle the components in production mode.
1. From the `/deploy` folder run the `deploy.ps1` script:

`.\deploy.ps1 -Manual -Environement LOCAL -Version 0.0.0`
Expand Down Expand Up @@ -47,7 +47,7 @@ To deploy the Storybook documentation, follow these steps:

1. From the solution root folder, run:

`npx lerna run docs:build --scope=@pnp/modern-search-core`
`npx lerna run docs:build --scope=pnp-modern-search-core`

1. From the `/deploy` folder run the `deploy.ps1` script:

Expand Down
8 changes: 4 additions & 4 deletions docs/development/getting_started.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
1. Open the project root folder in Visual Studio Code.
1. From the _'Terminal'_ window, run the following command:

`npx lerna run serve --scope=@pnp/modern-search-core`
`npx lerna run serve --scope=pnp-modern-search-core`

This will bundle the solution and serve it from a local server on adresss [http://localhost:8080/index.html](http://localhost:8080/index.html):

Expand All @@ -51,7 +51,7 @@
!["Test selection"](../assets/test_selection.png)

!!! notice
To run all tests (ex: before a commit), run `npx lerna run test --scope=@pnp/modern-search-core`:
To run all tests (ex: before a commit), run `npx lerna run test --scope=pnp-modern-search-core`:
!["Run all tests"](../assets/run_all_tests.png)

1. Launch the **"Debug tests Edge"** VSCode configuration and choose the test you want to debug:
Expand All @@ -70,7 +70,7 @@ We use Storybook to demo components in different scenarios:

To run Storybook locally run the following command:

`npx lerna run docs:watch --scope=@pnp/modern-search-core`
`npx lerna run docs:watch --scope=pnp-modern-search-core`

!!! notice
All stories are read from the `packages/components/src/stories` folder.
Expand All @@ -82,7 +82,7 @@ To run Storybook locally run the following command:
1. Open the project root folder in Visual Studio Code.
1. From the 'Terminal', run the following command:

`npx lerna run serve --scope=@pnp/modern-search-core-spfx`
`npx lerna run serve --scope=pnp-modern-search-core-spfx`

1. You can also go directly to ``packages/spfx` and run `npm run serve`.
1. Open the **Hosted workbench** debug configuration and add WebParts from Local category:
Expand Down
Loading

0 comments on commit 5c6da1a

Please sign in to comment.