Skip to content

Commit

Permalink
- Updated workflow
Browse files Browse the repository at this point in the history
  • Loading branch information
Franck Cornu committed Dec 8, 2023
1 parent f9fe7ba commit 8a12d8c
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 25 deletions.
6 changes: 2 additions & 4 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ jobs:
run: |
echo "majorMinorPatch=$GITVERSION_MAJORMINORPATCH" >> "$GITHUB_OUTPUT"
echo "semver=$GITVERSION_SEMVER" >> "$GITHUB_OUTPUT"
tests:
runs-on: ubuntu-latest
defaults:
Expand Down Expand Up @@ -255,14 +254,13 @@ jobs:
env:
CURRENT_VERSION: ${{ steps.package-version.outputs.currentVersion }}
NODE_AUTH_TOKEN: ${{ secrets.NPM_PUBLISH_TOKEN }}
CURRENT_BRANCH: ${{ github.ref }}
if: $CURRENT_VERSION != ${{ needs.version.outputs.semver }}
run: |
if [ "$CURRENT_BRANCH" == "refs/heads/develop" ]
if [ "$GITHUB_REF" == "refs/heads/develop" ]
then
npm publish --access=public --tag alpha
else
if [[ "$CURRENT_BRANCH" == *"refs/heads/release"* ]]
if [[ "$GITHUB_REF" == *"refs/heads/release"* ]]
then
npm publish --access=public --tag beta
else
Expand Down
2 changes: 1 addition & 1 deletion docs/development/concepts/solution.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ The solution uses the following technologies
| **Components code and logic** | [Web Component](https://developer.mozilla.org/en-US/docs/web/web_components) -> [Lit Element](https://lit.dev/docs/) -> [Microsoft Graph Toolkit](https://learn.microsoft.com/en-us/graph/toolkit/overview) -> Custom components. | All components basically extend the `MgtTemplatedComponent` base class from `@microsoft/mgt-element` library.
| **Components internal styling** | [TailwindCSS](https://tailwindcss.com/) | Allow to quickly style components without having to maintain dedicated stylesheets. A must have!
| **Components build** | [Webpack 5](https://webpack.js.org/) | Allow to precisely define the output we want to be able to distribute the components. Also comes with a dev server allowing local debug and tests (ex: `index.html`).
| **Test framework** | [Web Test Runner](https://modern-web.dev/docs/test-runner/overview/#web-test-runner) with [Playwright](https://playwright.dev/) | Configuration use ESBuild, Mocha, Chai and Sinon for tests.
| **Components demo and live documentation** | [Storybook](https://storybook.js.org/docs/web-components/get-started/install/) | Components attributes/proeprties documentation is generated automatically from the code comments through []`custom-elements.json`](https://storybook.js.org/docs/web-components/api/argtypes#automatic-argtype-inference) file. Storybook is configured to run with Webpack 5.
| **Test framework** | [Web Test Runner](https://modern-web.dev/docs/test-runner/overview/#web-test-runner) with [Pupeeter](https://pptr.dev/) | Configuration use ESBuild, Mocha, Chai and Sinon for tests.
| **Static documentation** | [MKdocs](https://www.mkdocs.org/) and Horizon platform | Technical static documentation is only accessible internally (unlike components documentation).

### Why using Microsoft Graph Toolkit instead of regular web components?
Expand Down
3 changes: 1 addition & 2 deletions packages/components/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,7 @@
"jspath": "0.4.0",
"lit": "^2.7.5",
"lodash-es": "4.17.21",
"markdown-it": "13.0.1",
"playwright": "^1.36.2"
"markdown-it": "13.0.1"
},
"devDependencies": {
"@babel/plugin-proposal-decorators": "7.22.7",
Expand Down
18 changes: 0 additions & 18 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 8a12d8c

Please sign in to comment.