From 8a12d8c939114a39c1f4803d6517492c25d74ea7 Mon Sep 17 00:00:00 2001 From: Franck Cornu Date: Fri, 8 Dec 2023 14:12:10 -0500 Subject: [PATCH] - Updated workflow --- .github/workflows/publish.yml | 6 ++---- docs/development/concepts/solution.md | 2 +- packages/components/package.json | 3 +-- pnpm-lock.yaml | 18 ------------------ 4 files changed, 4 insertions(+), 25 deletions(-) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index eaa301d..733bba5 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -39,7 +39,6 @@ jobs: run: | echo "majorMinorPatch=$GITVERSION_MAJORMINORPATCH" >> "$GITHUB_OUTPUT" echo "semver=$GITVERSION_SEMVER" >> "$GITHUB_OUTPUT" - tests: runs-on: ubuntu-latest defaults: @@ -255,14 +254,13 @@ jobs: env: CURRENT_VERSION: ${{ steps.package-version.outputs.currentVersion }} NODE_AUTH_TOKEN: ${{ secrets.NPM_PUBLISH_TOKEN }} - CURRENT_BRANCH: ${{ github.ref }} if: $CURRENT_VERSION != ${{ needs.version.outputs.semver }} run: | - if [ "$CURRENT_BRANCH" == "refs/heads/develop" ] + if [ "$GITHUB_REF" == "refs/heads/develop" ] then npm publish --access=public --tag alpha else - if [[ "$CURRENT_BRANCH" == *"refs/heads/release"* ]] + if [[ "$GITHUB_REF" == *"refs/heads/release"* ]] then npm publish --access=public --tag beta else diff --git a/docs/development/concepts/solution.md b/docs/development/concepts/solution.md index 231af22..436e805 100644 --- a/docs/development/concepts/solution.md +++ b/docs/development/concepts/solution.md @@ -5,8 +5,8 @@ The solution uses the following technologies | **Components code and logic** | [Web Component](https://developer.mozilla.org/en-US/docs/web/web_components) -> [Lit Element](https://lit.dev/docs/) -> [Microsoft Graph Toolkit](https://learn.microsoft.com/en-us/graph/toolkit/overview) -> Custom components. | All components basically extend the `MgtTemplatedComponent` base class from `@microsoft/mgt-element` library. | **Components internal styling** | [TailwindCSS](https://tailwindcss.com/) | Allow to quickly style components without having to maintain dedicated stylesheets. A must have! | **Components build** | [Webpack 5](https://webpack.js.org/) | Allow to precisely define the output we want to be able to distribute the components. Also comes with a dev server allowing local debug and tests (ex: `index.html`). -| **Test framework** | [Web Test Runner](https://modern-web.dev/docs/test-runner/overview/#web-test-runner) with [Playwright](https://playwright.dev/) | Configuration use ESBuild, Mocha, Chai and Sinon for tests. | **Components demo and live documentation** | [Storybook](https://storybook.js.org/docs/web-components/get-started/install/) | Components attributes/proeprties documentation is generated automatically from the code comments through []`custom-elements.json`](https://storybook.js.org/docs/web-components/api/argtypes#automatic-argtype-inference) file. Storybook is configured to run with Webpack 5. +| **Test framework** | [Web Test Runner](https://modern-web.dev/docs/test-runner/overview/#web-test-runner) with [Pupeeter](https://pptr.dev/) | Configuration use ESBuild, Mocha, Chai and Sinon for tests. | **Static documentation** | [MKdocs](https://www.mkdocs.org/) and Horizon platform | Technical static documentation is only accessible internally (unlike components documentation). ### Why using Microsoft Graph Toolkit instead of regular web components? diff --git a/packages/components/package.json b/packages/components/package.json index c282fdb..d148570 100644 --- a/packages/components/package.json +++ b/packages/components/package.json @@ -89,8 +89,7 @@ "jspath": "0.4.0", "lit": "^2.7.5", "lodash-es": "4.17.21", - "markdown-it": "13.0.1", - "playwright": "^1.36.2" + "markdown-it": "13.0.1" }, "devDependencies": { "@babel/plugin-proposal-decorators": "7.22.7", diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 48dd4b1..be2b8d2 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -89,9 +89,6 @@ importers: markdown-it: specifier: 13.0.1 version: 13.0.1 - playwright: - specifier: ^1.36.2 - version: 1.36.2 devDependencies: '@babel/plugin-proposal-decorators': specifier: 7.22.7 @@ -25561,21 +25558,6 @@ packages: find-up: 3.0.0 dev: true - /playwright-core@1.36.2: - resolution: {integrity: sha512-sQYZt31dwkqxOrP7xy2ggDfEzUxM1lodjhsQ3NMMv5uGTRDsLxU0e4xf4wwMkF2gplIxf17QMBCodSFgm6bFVQ==} - engines: {node: '>=16'} - hasBin: true - dev: false - - /playwright@1.36.2: - resolution: {integrity: sha512-4Fmlq3KWsl85Bl4InJw1NC21aeQV0iSZuFvTDcy1F8zVmXmgQRe89GxF8zMSRt/KIS+2tUolak7EXVl9aC+JdA==} - engines: {node: '>=16'} - hasBin: true - requiresBuild: true - dependencies: - playwright-core: 1.36.2 - dev: false - /please-upgrade-node@3.2.0: resolution: {integrity: sha512-gQR3WpIgNIKwBMVLkpMUeR3e1/E1y42bqDQZfql+kDeXd8COYfM8PQA4X6y7a8u9Ua9FHmsrrmirW2vHs45hWg==} dependencies: