remove redundant parameters

microsoft · Aug 7, 2023 · 64c165f · 64c165f
1 parent 21cc2cf
commit 64c165f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/.github/workflows/Deploy.yaml b/.github/workflows/Deploy.yaml
@@ -58,7 +58,7 @@ jobs:
                   "copyToMain" = ($env:copyToMain -eq 'Y')
                   "defaultBcContainerHelperVersion" = $env:defaultBcContainerHelperVersion
               }
-              . ".\Internal\Deploy.ps1" -config $config -githubOwner $githubOwner -token $token
+              . ".\Internal\Deploy.ps1" -config $config -token $token
             }
           }
           catch {

diff --git a/Internal/Deploy.ps1 b/Internal/Deploy.ps1
@@ -2,11 +2,7 @@
     [Parameter(Mandatory=$true)]
     [Hashtable] $config,
     [Parameter(Mandatory=$true)]
-    [string] $githubOwner,
-    [Parameter(Mandatory=$true)]
-    [string] $token,
-    [string] $algoBranch,
-    [switch] $directCommit
+    [string] $token
 )
 
 Import-Module (Join-Path $PSScriptRoot "..\Actions\Github-Helper.psm1" -Resolve) -DisableNameChecking
@@ -17,8 +13,8 @@ $oldPath = Get-Location
 try {
 
     # Authenticate to GIT and GH
-    invoke-git config --global user.email "$githubOwner@users.noreply.github.com"
-    invoke-git config --global user.name "$githubOwner"
+    invoke-git config --global user.email "$($config.githubOwner)@users.noreply.github.com"
+    invoke-git config --global user.name "$($config.githubOwner)"
     invoke-git config --global hub.protocol https
     invoke-git config --global core.autocrlf false
     $ENV:GITHUB_TOKEN = ''