Skip to content

Commit

Permalink
Bug fix for using self-hosted runners while having an Azure KeyVault …
Browse files Browse the repository at this point in the history
…connection (#745)

Check that C:\Modules (exists on GitHub hosted windows runners) exists
before enumerating it.

Co-authored-by: freddydk <freddydk@users.noreply.github.com>
  • Loading branch information
freddydk and freddydk authored Sep 30, 2023
1 parent 460e558 commit e5ab44c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion Actions/ReadSecrets/ReadSecretsHelper.psm1
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ function GetKeyVaultCredentials {
}

function InstallKeyVaultModuleIfNeeded {
if ($isWindows) {
if ($isWindows -and (Test-Path 'C:\Modules\az_*')) {
$azModulesPath = Get-ChildItem 'C:\Modules\az_*' | Where-Object { $_.PSIsContainer }
if ($azModulesPath) {
Write-Host $azModulesPath.FullName
Expand Down
1 change: 1 addition & 0 deletions RELEASENOTES.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ AL-Go for GitHub allows you to build and test using insider builds without any e

### Issues
- Issue 730 Support for external rulesets.
- Using self-hosted runners while using Azure KeyVault for secrets or signing might fail with C:\Modules doesn't exist

### New Settings
- `enableExternalRulesets`: set this setting to true if you want to allow AL-Go to automatically download external references in rulesets.
Expand Down

0 comments on commit e5ab44c

Please sign in to comment.