Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secretless PR Builds #641

Merged
merged 37 commits into from
Aug 7, 2023
Merged

Secretless PR Builds #641

merged 37 commits into from
Aug 7, 2023

Conversation

aholstrup1
Copy link
Collaborator

@aholstrup1 aholstrup1 commented Aug 2, 2023

This PR will add the ability to have trigger PRs with the pull_request trigger. Having PR builds triggered from the pull_request trigger means that builds triggered from forks won't have access to secrets.

  • Release notes
  • Testing

PR triggered with "pull_request" from branch: https://github.com/aholstrup1/ALAppExtensions/actions/runs/5750014584
PR triggered with "pull_request" from fork: https://github.com/aholstrup1/ALAppExtensions/actions/runs/5750987725/job/15588856379

@aholstrup1 aholstrup1 marked this pull request as ready for review August 2, 2023 07:12
@aholstrup1 aholstrup1 requested a review from a team as a code owner August 2, 2023 07:12
Copy link
Collaborator

@mazhelez mazhelez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also include a link to a test run to look at?

Scenarios/settings.md Outdated Show resolved Hide resolved
@mazhelez mazhelez changed the title [Draft] Secretless PR Builds Secretless PR Builds Aug 2, 2023
@aholstrup1
Copy link
Collaborator Author

aholstrup1 commented Aug 3, 2023

Can you also include a link to a test run to look at?

PR triggered with "pull_request" from branch: https://github.com/aholstrup1/ALAppExtensions/actions/runs/5750014584
PR triggered with "pull_request" from fork: https://github.com/aholstrup1/ALAppExtensions/actions/runs/5750987725/job/15588856379

Actions/CheckForUpdates/CheckForUpdates.ps1 Outdated Show resolved Hide resolved
Actions/CheckForUpdates/CheckForUpdates.ps1 Outdated Show resolved Hide resolved
RELEASENOTES.md Outdated Show resolved Hide resolved
Scenarios/settings.md Outdated Show resolved Hide resolved
aholstrup1 and others added 3 commits August 4, 2023 11:48
Co-authored-by: Maria Zhelezova <43066499+mazhelez@users.noreply.github.com>
Co-authored-by: Maria Zhelezova <43066499+mazhelez@users.noreply.github.com>
RELEASENOTES.md Outdated Show resolved Hide resolved
Co-authored-by: Maria Zhelezova <43066499+mazhelez@users.noreply.github.com>
@aholstrup1 aholstrup1 enabled auto-merge (squash) August 6, 2023 13:56
Copy link
Collaborator

@mazhelez mazhelez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo

Actions/AL-Go-Helper.ps1 Outdated Show resolved Hide resolved
Actions/CheckForUpdates/CheckForUpdates.ps1 Outdated Show resolved Hide resolved
Actions/CheckForUpdates/CheckForUpdates.ps1 Outdated Show resolved Hide resolved
Actions/CheckForUpdates/CheckForUpdates.ps1 Outdated Show resolved Hide resolved
RELEASENOTES.md Outdated Show resolved Hide resolved
Scenarios/settings.md Outdated Show resolved Hide resolved
Copy link
Contributor

@freddydk freddydk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @mazhelez comments on PullRequestTrigger over PullrequestTrigger

@aholstrup1 aholstrup1 merged commit 605b064 into microsoft:main Aug 7, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants