-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Secretless PR Builds #641
Secretless PR Builds #641
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also include a link to a test run to look at?
Templates/AppSource App/.github/workflows/_BuildALGoProject.yaml
Outdated
Show resolved
Hide resolved
PR triggered with "pull_request" from branch: https://github.com/aholstrup1/ALAppExtensions/actions/runs/5750014584 |
Co-authored-by: Maria Zhelezova <43066499+mazhelez@users.noreply.github.com>
Co-authored-by: Maria Zhelezova <43066499+mazhelez@users.noreply.github.com>
Co-authored-by: Maria Zhelezova <43066499+mazhelez@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with @mazhelez comments on PullRequestTrigger over PullrequestTrigger
This PR will add the ability to have trigger PRs with the pull_request trigger. Having PR builds triggered from the pull_request trigger means that builds triggered from forks won't have access to secrets.
PR triggered with "pull_request" from branch: https://github.com/aholstrup1/ALAppExtensions/actions/runs/5750014584
PR triggered with "pull_request" from fork: https://github.com/aholstrup1/ALAppExtensions/actions/runs/5750987725/job/15588856379