-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ALDoc support in AL-Go #760
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some non-blocking comments.
After the new github.ref_name == 'main'
check for the new job in the CI/CD workflow, I'm even more convinced that a separate workflow is the better approach.
I have some doubts about the scheduling functionality of the new "Deploy Reference Documentation" workflow. Seems unlikely to build the documentation on a schedule.
Good job on the E2E tests for the new workflow.
Actions/BuildReferenceDocumentation/BuildReferenceDocumentation.HelperFunctions.ps1
Show resolved
Hide resolved
Actions/BuildReferenceDocumentation/BuildReferenceDocumentation.HelperFunctions.ps1
Outdated
Show resolved
Hide resolved
Actions/BuildReferenceDocumentation/BuildReferenceDocumentation.HelperFunctions.ps1
Outdated
Show resolved
Hide resolved
Actions/BuildReferenceDocumentation/BuildReferenceDocumentation.HelperFunctions.ps1
Outdated
Show resolved
Hide resolved
…n.HelperFunctions.ps1 Co-authored-by: Maria Zhelezova <43066499+mazhelez@users.noreply.github.com>
TO:DO
Tasks
Implementation
New Settings: ALDoc structure
The following settings structure will be added to repository settings (with default values):
Where:
ALDoc.Header, ALDoc.Footer, ALDoc.DefaultIndexMD and ALDoc.DefaultReleaseMD can have the following placeholders, which will be replaced by their actual values during generation:
New Action: BuildALDoc
New action, which builds the ALDoc documentation for the apps in the .artifacts folder and places it in .aldoc/_site
It includes the projects specified in ALDoc.Projects (or all if not specified) and excludes the projects from ALDoc.ExcludeProjects.
It uses ALDoc.Header, ALDoc.Footer when invoking docfx.
It uses ALDoc.DefaultIndexMD as index.md for the reference docs and ALDoc.DefaultReleaseMD as index.md for reference docs for released versions.
The action also generates reference documentation for a number of prior releases (determined by setting ALDoc.MaxReleases) and adds those to the documentation site as well (under releases/version)
Modified Workflow: CI/CD
New job added: Deploy ALDoc documentation, invoked if ALDoc.ContinuousDeployment is true.
If ALDoc.DeployToGitHubPages is true (which is default) the workflow automatically deploys to GitHub pages (if supported by the SKU)
New Workflow: Deploy Reference Documentation
If ALDoc.ContinuousDeployment is false (or if you want to redeploy) you can invoke this workflow to manually generate and publish the reference documentation.
If ALDoc.DeployToGitHubPages is true (which is default) the workflow automatically deploys to GitHub pages (if supported by the SKU)
Try it out
Update AL-Go system files with freddydk/AL-Go@aldoc