Dependencies from prior build jobs are not included when using useProjectDependencies #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mazhelez
reviewed
Nov 16, 2023
mazhelez
previously approved these changes
Nov 17, 2023
elbardel
previously approved these changes
Nov 17, 2023
aholstrup1
approved these changes
Nov 19, 2023
mazhelez
approved these changes
Nov 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #823
This pull request includes changes related to the handling of dependencies artifacts in several files. The most important changes include adding a new step to upload dependencies artifacts, modifying the
ifcondition for uploading dependency artifacts, and updating theGetDependenciesfunction to include the dependencies folder in its search for dependencies.Dependency handling changes:
Templates/Per Tenant Extension/.github/workflows/_BuildALGoProject.yaml: Added a new step to upload dependencies artifacts and added thegenerateDependencyArtifactinput to thegetparameter in two jobs. (F1a2b3c4R1)Actions/Github-Helper.psm1: Updated theGetDependenciesfunction to include the dependencies folder in its search for dependencies. (F2d3e4f5R1)Templates/AppSource App/.github/workflows/_BuildALGoProject.yaml: Modified theifcondition for uploading dependency artifacts to check if thegenerateDependencyArtifactenvironment variable is true before uploading. (F3g4h5i6R1)Other changes:
Actions/CalculateArtifactNames/action.yaml: Added a new output variable for dependencies artifacts name to theCalculateArtifactNamesaction. (F4j5k6l7R1)RELEASENOTES.md: Added a new issue to the release notes. (F7m8n9o1R1)Actions/CalculateArtifactNames/README.md: Added a new output variable calledThisBuildDependenciesArtifactsNameto the table in theActions/CalculateArtifactNames/README.mdfile. (F0p1q2r3R1)Actions/CalculateArtifactNames/CalculateArtifactNames.ps1: Updated theSet-OutputVariablecommand to include the dependencies folder in the search for dependencies. (F4s5t6u7R1)Actions/RunPipeline/RunPipeline.ps1: Updated thegenerateDependencyArtifactparameter to be a boolean value. (F8v9w1x2R1)