Fix partial build #837
Merged
Fix partial build #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cremental-build
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Actions/DownloadProjectDependencies/DownloadProjectDependencies.Action.ps1
Fixed
Show fixed
Hide fixed
aholstrup1
previously approved these changes
Dec 8, 2023
Actions/DetermineProjectsToBuild/DetermineProjectsToBuild.Action.ps1
Outdated
Show resolved
Hide resolved
Co-authored-by: Alexander Holstrup <117829001+aholstrup1@users.noreply.github.com>
Co-authored-by: Alexander Holstrup <117829001+aholstrup1@users.noreply.github.com>
…L-Go into fix-incremental-build
freddydk
reviewed
Dec 9, 2023
Templates/Per Tenant Extension/.github/workflows/PullRequestHandler.yaml
Outdated
Show resolved
Hide resolved
freddydk
reviewed
Dec 11, 2023
freddydk
approved these changes
Dec 11, 2023
aholstrup1
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Currently, when building partially (e.g. PR Build), the baseline artifacts are fetched from a CICD workflow run on the fly.
This could lead to discrepancies: one build job downloading artifacts from one CICD run, while the next one: from another CICD run (which completed in-between the two build jobs in the PR Build).
Solution: Determine the baseline CICD workflow once per PR Build and use artifacts from it in all build jobs.
Test run partial build: https://github.com/mazhelez/BCApps/actions/runs/7165434696?pr=2
Test run full build: https://github.com/mazhelez/BCApps/actions/runs/7165432643?pr=5
TODO: