New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve IncrementVersionNumber action #910

Merged

mazhelez merged 35 commits into microsoft:main from mazhelez:fix-CreateRelease

Feb 12, 2024

Collaborator

mazhelez commented Jan 31, 2024 •

edited

Loading

Fixes #889 : appFolders with wild characters are not resolved when reading the app.json files.
Also fixes issue that the version property in dependencies array in the app.json is not changed.

Release notes
More tests

mazhelez and others added 8 commits

January 24, 2024 15:49


          Validate version number

d27df11


          Fix increment version logic to work with wild cards in appFolders and…

736252e

… testFolders


          Better naming + doc

7eef2a8


          Rename value

9c821bb


          Fix var name

7d5dbf6


          Add tests for Set-SettingInFile

bac2fa4


          Make Set-ProjectVersion work with projectSettings

f0ab04d


          Merge branch 'main' into fix-CreateRelease

195b5f4

mazhelez commented

View reviewed changes

Actions/IncrementVersionNumber/IncrementVersionNumber.psm1 Outdated Show resolved Hide resolved

mazhelez commented

View reviewed changes

Actions/IncrementVersionNumber/IncrementVersionNumber.psm1 Outdated Show resolved Hide resolved

mazhelez commented

View reviewed changes

Actions/IncrementVersionNumber/IncrementVersionNumber.psm1 Outdated Show resolved Hide resolved

mazhelez added 3 commits

January 31, 2024 11:26


          Refactor to re-use Set-SettingInFile

cfdda55


          Fix newVersion reference

b6dee6d


          Clean-up, add comments, etc.

34aa16b

mazhelez commented

View reviewed changes

Actions/IncrementVersionNumber/IncrementVersionNumber.psm1 Outdated Show resolved Hide resolved

mazhelez added 2 commits

January 31, 2024 11:44


          Merge branch 'fix-CreateRelease' of https://github.com/mazhelez/AL-Go …

0a57bad

…into fix-CreateRelease


          Fix parameter name

c5e21e8

aholstrup1 reviewed

View reviewed changes

Actions/IncrementVersionNumber/IncrementVersionNumber.ps1 Outdated Show resolved Hide resolved

Actions/IncrementVersionNumber/IncrementVersionNumber.psm1 Outdated Show resolved Hide resolved

mazhelez added 6 commits

February 1, 2024 15:29


          Improve version changing functionality

fdd6c32


          Move "incremental" logic in Set-VersionSettingInFile

4f038c9


          Add/improve tests

7a0ac95


          Add some code comments

df513c8


          Clean up doc

0e50768


          Add release notes

cfad51e

mazhelez marked this pull request as ready for review

February 1, 2024 15:34

mazhelez requested a review from a team as a code owner

February 1, 2024 15:34

mazhelez requested review from aholstrup1 and freddydk

February 1, 2024 15:34

mazhelez added 2 commits

February 1, 2024 17:16


          Pass ALGOsettingsFile as param

4e1e67a


          Set version property in the dependencies array in the app.json

55a5d58

mazhelez commented

View reviewed changes

Actions/IncrementVersionNumber/IncrementVersionNumber.psm1 Outdated Show resolved Hide resolved

mazhelez added 2 commits

February 8, 2024 15:53


          Change design of incrementing version:

5ed6470

+1: increments major version and sets minor to 0
+0.1: increments minor version
major.minor: sets the specified versions


          Set dependencies version in app manifest files (app.json)

d367b95

github-advanced-security bot found potential problems

View reviewed changes

Actions/IncrementVersionNumber/IncrementVersionNumber.psm1 Fixed Show fixed Hide fixed

Actions/IncrementVersionNumber/IncrementVersionNumber.psm1 Fixed Show fixed Hide fixed

mazhelez added 7 commits

February 8, 2024 17:26


          Add doc for Set-DependenciesVersionInAppManifests

b20a6cd


          Remove ValueFromPipeline (unused anyway)

3f885fd


          Remove version validation (it's validated when set)

5138ce8


          Fix var ref

b7ee172


          Fix versionNumber doc


          Fix versionNumber doc (2)

df2a6c7


          Fix param refernce

cc05a3a

freddydk approved these changes

View reviewed changes

Contributor

freddydk left a comment

Looks good

Actions/IncrementVersionNumber/IncrementVersionNumber.psm1 Outdated Show resolved Hide resolved

Actions/IncrementVersionNumber/IncrementVersionNumber.psm1 Show resolved Hide resolved

freddydk requested changes

View reviewed changes

Contributor

freddydk left a comment

We need to set RepoVersion in the settings file always.

freddydk requested changes

View reviewed changes

Actions/IncrementVersionNumber/IncrementVersionNumber.psm1 Outdated Show resolved Hide resolved

Actions/IncrementVersionNumber/IncrementVersionNumber.psm1 Outdated Show resolved Hide resolved

Actions/IncrementVersionNumber/IncrementVersionNumber.psm1 Outdated Show resolved Hide resolved

mazhelez added 5 commits

February 9, 2024 23:19


          Use -Encoding UTF8 when reading JSON files

abbfa8d


          Use Set-JsonContentLF


          Add logs

1441efb


          Add docs

1dba93d


          Ensure repoVersion is set in the repo settings.

78bba82

Add Force parameter on Set-VersionInSettingsFile

mazhelez requested a review from freddydk

February 10, 2024 00:41

freddydk approved these changes

View reviewed changes

elbardel approved these changes

View reviewed changes

mazhelez merged commit 8c97a30 into microsoft:main

4 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet