Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating DevOps Security Data with Location Url #2844

Merged
merged 14 commits into from
Jan 15, 2025

Conversation

laragoldstein13
Copy link
Contributor

@laragoldstein13 laragoldstein13 commented Nov 26, 2024

Summary

Adding Location data to allow customers to view the affected file or the alert generated to produce the finding.

Screenshots

  • If you added a template to a gallery, show a screenshot of it in the gallery view (which verifies its shows up where you expected).

    It is also good to show a screenshot of template content, so people can see what you expect it to look like, compared to what they see when they might run it themselves.

Validation

  • Validate your changes using one or more of the testing methods.

    Make sure you've tested your template content. Fixing things while in PR is trivial. Hotfixing it later is very expensive; at the current time at least 3 teams are involved in a hotfix!

Checklist

  • If you are adding a new template, gallery, or folder, add your team and folder/file(s) to the CODEOWNERS file at the root of the repo. CODEOWNERS entries should be teams, not individuals.
    When done correctly, this means that from then on your team does reviews of your things, not the workbooks team.
  • Ensure all steps in your template have meaningful names.
  • Ensure all parameters and grid columns have display names set so they can be localized.

@laragoldstein13 laragoldstein13 requested a review from a team as a code owner November 26, 2024 16:26
@laragoldstein13
Copy link
Contributor Author

@liorarviv whenever you have the chance, could you please approve this PR? Thank you!

@laragoldstein13 laragoldstein13 merged commit bfc542d into microsoft:master Jan 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants