Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sql insights from workbook gallery #2873

Merged
merged 3 commits into from
Jan 16, 2025
Merged

Conversation

masree
Copy link
Contributor

@masree masree commented Jan 16, 2025

Summary

SQL Insights officially got retired on 31 December 2024. Removing its reference from workbook insights gallery

Screenshots

  • If you added a template to a gallery, show a screenshot of it in the gallery view (which verifies its shows up where you expected).
    image

    It is also good to show a screenshot of template content, so people can see what you expect it to look like, compared to what they see when they might run it themselves.

Validation

  • Validate your changes using one or more of the testing methods.
    Validated, no SQL Insights under "Insights" gallery

    Make sure you've tested your template content. Fixing things while in PR is trivial. Hotfixing it later is very expensive; at the current time at least 3 teams are involved in a hotfix!

Checklist

  • If you are adding a new template, gallery, or folder, add your team and folder/file(s) to the CODEOWNERS file at the root of the repo. CODEOWNERS entries should be teams, not individuals.
    When done correctly, this means that from then on your team does reviews of your things, not the workbooks team.
  • Ensure all steps in your template have meaningful names.
  • Ensure all parameters and grid columns have display names set so they can be localized.

@masree masree requested a review from a team as a code owner January 16, 2025 02:13
@masree masree marked this pull request as draft January 16, 2025 02:13
@masree masree requested a review from a team January 16, 2025 02:19
@masree masree marked this pull request as ready for review January 16, 2025 02:19
@masree masree merged commit 3b47c10 into master Jan 16, 2025
4 checks passed
@masree masree deleted the masree/removeSQLGallery branch January 17, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants