Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update retirement text for sql insights #2874

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Update retirement text for sql insights #2874

merged 2 commits into from
Jan 16, 2025

Conversation

masree
Copy link
Contributor

@masree masree commented Jan 16, 2025

Summary

SQL Insights has been deprecated on 31 Dec 2024 - updating the retirement content

Screenshots

  • If you added a template to a gallery, show a screenshot of it in the gallery view (which verifies its shows up where you expected).

    It is also good to show a screenshot of template content, so people can see what you expect it to look like, compared to what they see when they might run it themselves.

Validation

  • Validate your changes using one or more of the testing methods.

    Make sure you've tested your template content. Fixing things while in PR is trivial. Hotfixing it later is very expensive; at the current time at least 3 teams are involved in a hotfix!

Checklist

  • If you are adding a new template, gallery, or folder, add your team and folder/file(s) to the CODEOWNERS file at the root of the repo. CODEOWNERS entries should be teams, not individuals.
    When done correctly, this means that from then on your team does reviews of your things, not the workbooks team.
  • Ensure all steps in your template have meaningful names.
  • Ensure all parameters and grid columns have display names set so they can be localized.

Update retirement text for sql insights
@masree masree requested a review from a team as a code owner January 16, 2025 02:33
Copy link
Collaborator

@gardnerjr gardnerjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me, the question is: do you want to remove ALL of the other content other than the retirement messsage now?

if it is retired and onboading instructions below don't actually apply anymore, why still have them?

if you have specific blades you normally open now, you could add those as action links that using custom views that open the actual blades inside the portal instead of just redirecting to urls?

@masree
Copy link
Contributor Author

masree commented Jan 16, 2025

For me, the question is: do you want to remove ALL of the other content other than the retirement messsage now?

if it is retired and onboading instructions below don't actually apply anymore, why still have them?

if you have specific blades you normally open now, you could add those as action links that using custom views that open the actual blades inside the portal instead of just redirecting to urls?

Yes we'll remove all the other content(templates) in a future PR after 1-2 months of blocking all entry points

@masree masree merged commit 0193acb into master Jan 16, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants