Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3910][JavaScript] Add Bot Authentication SNI sample bot #3914

Merged
merged 8 commits into from
Oct 25, 2023

Conversation

JhontSouth
Copy link
Collaborator

#minor
#addresses #3910

Description

This PR adds a new sample for Javascript_nodejs that shows how to authenticate the Azure bot using the Subject Name/Issuer from MSAL.

Proposed Changes

  • Added the new sample bot-authentication-sni.
  • Added a simple bot conversation to validate the authentication.
  • Added README file with the instructions and information about the sample and how to create a SSL/TSL certificate.

Testing

This image shows the new bot-authentication-sni sample working.
image

@JhontSouth JhontSouth requested a review from a team as a code owner October 10, 2023 18:36
@JhontSouth
Copy link
Collaborator Author

@microsoft-github-policy-service agree

@tracyboehrer tracyboehrer merged commit 038bda5 into main Oct 25, 2023
4 checks passed
@tracyboehrer tracyboehrer deleted the southworks/add/bot-authentication-sn+i-sample branch October 25, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants