Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4009] Update samples to support latest Node version - TypeScript #4011

Merged
merged 7 commits into from
Sep 25, 2024

Conversation

ceciliaavila
Copy link
Collaborator

Addresses #4009

Description

This PR updates the ARM templates of the TypeScript samples to use Node 20 as default.

Proposed Changes

  • Updated Node to version 20 in all ARM templates.
  • Upgraded the restify dependency to version 10.0.0 and the @types/restify to 8.5.12.
  • Fixed error with missing moment module in 13.core-bot sample.
  • Fixed missing 'next' parameter in '/api/messages' handler to comply with new restify's requirements.
  • Updated Node required version in README files.
  • Added esModuleInterop = true to fix errors with imports in dependencies.

Testing

These images show the resources created in Azure and a bot working after the deployment.
image

@ceciliaavila ceciliaavila requested a review from a team as a code owner August 29, 2024 20:27
@tracyboehrer tracyboehrer merged commit e5b6d01 into main Sep 25, 2024
9 checks passed
@tracyboehrer tracyboehrer deleted the southworks/update/node-20-ts branch September 25, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants