actors.h does not need to be public

CMakeLists.txt

@@ -224,6 +224,7 @@ set(CCF_ENDPOINTS_SOURCES
     ${CCF_DIR}/src/endpoints/endpoint_registry.cpp
     ${CCF_DIR}/src/endpoints/base_endpoint_registry.cpp
     ${CCF_DIR}/src/endpoints/common_endpoint_registry.cpp
+    ${CCF_DIR}/src/endpoints/user_endpoint_registry.cpp
     ${CCF_DIR}/src/endpoints/json_handler.cpp
     ${CCF_DIR}/src/endpoints/authentication/cose_auth.cpp
     ${CCF_DIR}/src/endpoints/authentication/cert_auth.cpp

include/ccf/app_interface.h

@@ -2,7 +2,6 @@
 // Licensed under the Apache 2.0 License.
 #pragma once
 
-#include "ccf/actors.h"
 #include "ccf/ccf_deprecated.h"
 #include "ccf/common_endpoint_registry.h"
 #include "ccf/js_plugin.h"
@@ -27,24 +26,18 @@ namespace ccf
   class UserEndpointRegistry : public CommonEndpointRegistry
   {
   public:
-    UserEndpointRegistry(ccf::AbstractNodeContext& context) :
-      CommonEndpointRegistry(get_actor_prefix(ActorsType::users), context)
-    {}
+    UserEndpointRegistry(ccf::AbstractNodeContext& context);
 
     // Default behaviour is to do nothing - do NOT log summary of every request
     // as it completes. Apps may override this if they wish.
     void handle_event_request_completed(
-      const ccf::endpoints::RequestCompletedEvent& event) override
-    {}
+      const ccf::endpoints::RequestCompletedEvent& event) override;
 
+    // Default behavour is to log dispatch failures, as a coarse metric of
+    // some user errors, but do not log the raw path, which may contain
+    // confidential fields misformatted into the wrong url
     void handle_event_dispatch_failed(
-      const ccf::endpoints::DispatchFailedEvent& event) override
-    {
-      // Log dispatch failures, as a coarse metric of some user errors, but do
-      // not log the raw path, which may contain confidential fields
-      // misformatted into the wrong url
-      CCF_APP_INFO("DispatchFailedEvent: {} {}", event.method, event.status);
-    }
+      const ccf::endpoints::DispatchFailedEvent& event) override;
   };
 }
 

src/apps/js_generic/js_generic_base.cpp

@@ -22,6 +22,7 @@
 #include "ccf/node/host_processes_interface.h"
 #include "ccf/service/tables/jsengine.h"
 #include "ccf/version.h"
+#include "ds/actors.h"
 #include "enclave/enclave_time.h"
 #include "js/global_class_ids.h"
 #include "node/rpc_context_impl.h"

src/enclave/rpc_map.h

@@ -2,7 +2,7 @@
 // Licensed under the Apache 2.0 License.
 #pragma once
 
-#include "ccf/actors.h"
+#include "ds/actors.h"
 #include "rpc_handler.h"
 
 namespace ccf

src/endpoints/user_endpoint_registry.cpp

@@ -0,0 +1,23 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the Apache 2.0 License.
+
+#include "ccf/app_interface.h"
+#include "ds/actors.h"
+
+namespace ccf
+{
+  UserEndpointRegistry::UserEndpointRegistry(
+    ccf::AbstractNodeContext& context) :
+    CommonEndpointRegistry(get_actor_prefix(ActorsType::users), context)
+  {}
+
+  void UserEndpointRegistry::handle_event_request_completed(
+    const ccf::endpoints::RequestCompletedEvent& event)
+  {}
+
+  void UserEndpointRegistry::handle_event_dispatch_failed(
+    const ccf::endpoints::DispatchFailedEvent& event)
+  {
+    CCF_APP_INFO("DispatchFailedEvent: {} {}", event.method, event.status);
+  }
+}

src/http/http_rpc_context.h

@@ -2,10 +2,10 @@
 // Licensed under the Apache 2.0 License.
 #pragma once
 
-#include "ccf/actors.h"
 #include "ccf/http_responder.h"
 #include "ccf/odata_error.h"
 #include "ccf/rpc_context.h"
+#include "ds/actors.h"
 #include "http_parser.h"
 #include "node/rpc_context_impl.h"
 

src/js/registry.cpp

@@ -36,6 +36,7 @@
 #include "ccf/js/modules/chained_module_loader.h"
 #include "ccf/js/modules/kv_bytecode_module_loader.h"
 #include "ccf/js/modules/kv_module_loader.h"
+#include "ds/actors.h"
 #include "node/rpc_context_impl.h"
 
 namespace ccf::js

src/node/acme_challenge_frontend.h

@@ -2,10 +2,10 @@
 // Licensed under the Apache 2.0 License.
 #pragma once
 
-#include "ccf/actors.h"
 #include "ccf/common_auth_policies.h"
 #include "ccf/common_endpoint_registry.h"
 #include "ccf/endpoint_registry.h"
+#include "ds/actors.h"
 #include "node/network_state.h"
 #include "node/rpc/frontend.h"