Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IAT claim in cose sign #6565

Merged
merged 8 commits into from
Oct 15, 2024
Merged

Conversation

maxtropets
Copy link
Collaborator

@maxtropets maxtropets commented Oct 12, 2024

As per https://www.rfc-editor.org/rfc/rfc8392.html#section-3.1.6

Currently using time() directly.

@achamayou I think we can use it in SNP, can't we? Or shall we keep using ccf::enclavetime?

@maxtropets maxtropets self-assigned this Oct 12, 2024
@maxtropets maxtropets requested a review from a team October 12, 2024 13:14
@achamayou
Copy link
Member

@maxtropets let's continue to use enclavetime, because it's useful to be able to control the clock centrally for test purposes.

@maxtropets maxtropets added the run-long-test Run Long Test job label Oct 14, 2024
@achamayou
Copy link
Member

"iat" needs to be nested in a "CWT_Claims" map (15): https://datatracker.ietf.org/doc/rfc9597/

@maxtropets
Copy link
Collaborator Author

"iat" needs to be nested in a "CWT_Claims" map (15): https://datatracker.ietf.org/doc/rfc9597/

Done, please review

@maxtropets maxtropets enabled auto-merge October 15, 2024 00:30
@achamayou
Copy link
Member

I suggest setting up a test that uses the cddl tool to check the schema here, because it's stricter than the Python cbor2 library, which is quite liberal in its type mapping.

@achamayou
Copy link
Member

@maxtropets also needs a changelog entry, but maybe that's better done once it can contain a link to a schema

@maxtropets maxtropets disabled auto-merge October 15, 2024 10:19
@maxtropets
Copy link
Collaborator Author

I suggest setting up a test that uses the cddl tool to check the schema here, because it's stricter than the Python cbor2 library, which is quite liberal in its type mapping.

#6561

@maxtropets maxtropets added this pull request to the merge queue Oct 15, 2024
Merged via the queue into microsoft:main with commit dae8c25 Oct 15, 2024
13 checks passed
@maxtropets maxtropets deleted the f/cose-pheaders-iat-claim branch October 15, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-long-test Run Long Test job
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants