Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DirectXTex.h #529

Closed
wants to merge 2 commits into from
Closed

Update DirectXTex.h #529

wants to merge 2 commits into from

Conversation

karurung
Copy link

@karurung karurung commented Oct 6, 2024

'void*' to 'uint8_t*'

@karurung
Update DirectXTex.h
cd88f0b 
'void*' to 'uint8_t*'
@walbourn
Copy link
Member

walbourn commented Oct 7, 2024

EncodeDDSHeader updates are missing.

@walbourn
Update DirectXTex.h
9e1dd17 
Code review
@walbourn
Copy link
Member

walbourn commented Oct 7, 2024

This PR needs updated to include the matching fixes to the cpp files.

DirectXTexDDS.cpp 
DirectXTexHDR.cpp
DirectXTexTGA.cpp
DirectXTexWIC.cpp

Please include these file changes in THIS PR and not in distinct ones as that is hard to test and will fail GitHub Action validation.

@karurung
Copy link
Author

karurung commented Oct 8, 2024

Sorry, I'm new to creating Pull Requests (PRs) and I'm not sure how to proceed.

@karurung karurung closed this Oct 11, 2024
@walbourn walbourn reopened this Oct 24, 2024
@walbourn
Copy link
Member

#538

@walbourn walbourn closed this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karurung @walbourn