Fix pretty print for tables (#2232)

microsoft · Feb 23, 2024 · e26195c · e26195c
1 parent aae6765
commit e26195c
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 5 deletions.
diff --git a/src/libraries/Microsoft.PowerFx.Core/Syntax/TexlPretty.cs b/src/libraries/Microsoft.PowerFx.Core/Syntax/TexlPretty.cs
@@ -67,8 +67,8 @@ public override LazyList<string> Visit(NumLitNode node, Precedence parentPrecede
             Contracts.AssertValue(node);
 
             var nlt = node.Value;
-            
-            // $$$ can't use current culture
+
+            // $$$ can't use current culture
             return LazyList<string>.Of(nlt != null ? nlt.ToString() : node.NumValue.ToString("R", CultureInfo.CurrentCulture));
         }
 
@@ -77,7 +77,7 @@ public override LazyList<string> Visit(DecLitNode node, Precedence parentPrecede
             Contracts.AssertValue(node);
 
             var nlt = node.Value;
-            
+
             // $$$ can't use current culture
             return LazyList<string>.Of(nlt != null ? nlt.ToString() : node.DecValue.ToString("G29", CultureInfo.CurrentCulture));
         }
@@ -399,8 +399,8 @@ public override LazyList<string> Visit(TableNode node, Precedence parentPreceden
             result = LazyList<string>.Of(TexlLexer.PunctuatorBracketOpen, " ")
                 .With(result)
                 .With(" ", TexlLexer.PunctuatorBracketClose);
-
-            return ApplyPrecedence(parentPrecedence, Precedence.SingleExpr, result);
+
+            return result;
         }
 
         public virtual string GetRightToken(TexlNode leftNode, Identifier right)

diff --git a/src/tests/Microsoft.PowerFx.Core.Tests/TexlTests.cs b/src/tests/Microsoft.PowerFx.Core.Tests/TexlTests.cs
@@ -4083,6 +4083,21 @@ public void TexlFunctionTypeSemanticColumn_Negative(string expression)
             Assert.False(result.IsSuccess);
         }
 
+        [Theory]
+        [InlineData("in")]
+        [InlineData("exactin")]
+        public void PrettyPrintTest(string op)
+        {
+            string expr = $"1 {op} [0]";
+
+            CheckResult check = new CheckResult(new Engine()).SetText(expr);
+            ParseResult parse = check.ApplyParse();
+
+            string str = parse.Root.ToString();
+
+            Assert.Equal($"1 {op} [ 0 ]", str);
+        }
+
         internal class BlobFunc : TexlFunction
         {
             public override bool IsSelfContained => false;