Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove support for sync transport attributes #2645

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: remove support for sync transport attributes #2645

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions src/libraries/Microsoft.PowerFx.Transport.Attributes/TransportMethodAttribute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,8 @@ namespace Microsoft.AppMagic.Transport
[AttributeUsage(AttributeTargets.Method)]
public class TransportMethodAttribute : Attribute
{
public TransportMethodAttribute(bool supportSynchronousClient = false, TransportBatchingMode batchingMode = TransportBatchingMode.Default, bool isParallel = false)
public TransportMethodAttribute(TransportBatchingMode batchingMode = TransportBatchingMode.Default, bool isParallel = false)
{
SupportSynchronousClient = supportSynchronousClient;
BatchingMode = batchingMode;
IsParallel = isParallel;
}
Expand All @@ -23,11 +22,6 @@ public TransportMethodAttribute(bool supportSynchronousClient = false, Transport
/// </summary>
public bool Deferred { get; }

/// <summary>
/// For back-compat, support blocking callers.
/// </summary>
public bool SupportSynchronousClient { get; }

/// <summary>
/// Defines batching.
/// </summary>
Expand Down
11 changes: 1 addition & 10 deletions src/libraries/Microsoft.PowerFx.Transport.Attributes/TransportPropertyAttribute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,20 +11,11 @@ namespace Microsoft.AppMagic.Transport
[AttributeUsage(AttributeTargets.Property | AttributeTargets.Field)]
public class TransportPropertyAttribute : Attribute
{
public TransportPropertyAttribute(bool generateSynchronousSetterTemplateInProxyClass = false, bool useDiffSync = false)
public TransportPropertyAttribute(bool useDiffSync = false)
{
GenerateSynchronousSetterTemplateInProxyClass = generateSynchronousSetterTemplateInProxyClass;
UseDiffSync = useDiffSync;
}

/// <summary>
/// When defined, generates a synchronous setter method that redirects to "set{PropertyName}". This
/// allows the programmer to manually define how set calls should be marshalled. The user is still
/// responsible for defining the appropriate setter method in either the base class or original
/// C# class.
/// </summary>
public bool GenerateSynchronousSetterTemplateInProxyClass { get; }

/// <summary>
/// If the marked property is a <c>ITrackedCollection</c>, and it gets updated,
/// state synchronization will not send the entire collection to the client, only
Expand Down