This repository has been archived by the owner on Jan 12, 2024. It is now read-only.
Update notebook samples for resource estimation visualization #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msoeken
suggested changes
Aug 2, 2023
samples/azure-quantum/resource-estimation/estimation-dynamics.ipynb
Outdated
Show resolved
Hide resolved
samples/azure-quantum/resource-estimation/estimation-dynamics.ipynb
Outdated
Show resolved
Hide resolved
samples/azure-quantum/resource-estimation/estimation-dynamics.ipynb
Outdated
Show resolved
Hide resolved
samples/azure-quantum/resource-estimation/estimation-dynamics.ipynb
Outdated
Show resolved
Hide resolved
samples/azure-quantum/resource-estimation/estimation-dynamics.ipynb
Outdated
Show resolved
Hide resolved
samples/azure-quantum/resource-estimation/estimation-dynamics.ipynb
Outdated
Show resolved
Hide resolved
| @@ -380,6 +495,63 @@ | |||
| "All other parameters remain unchanged." | |||
There was a problem hiding this comment.
Before the change, the code change to update the parameters came right after this explanation. Now there is a break in the flow with the time charts introduced before continuing with the updated parameters.
There was a problem hiding this comment.
yes this is a good point, i wanted to include the time and space diagrams in the results section but wasnt sure what to do with this section. I moved it to be under the time chart. Let me know what you think about that instead. It could also go right below the results summary table and then we have the space and time diagrams.
samples/azure-quantum/resource-estimation/estimation-dynamics.ipynb
Outdated
Show resolved
Hide resolved
samples/azure-quantum/resource-estimation/estimation-dynamics.ipynb
Outdated
Show resolved
Hide resolved
…ipynb Co-authored-by: Mathias Soeken <mathias.soeken@microsoft.com>
…ipynb Co-authored-by: Mathias Soeken <mathias.soeken@microsoft.com>
…ipynb Co-authored-by: Mathias Soeken <mathias.soeken@microsoft.com>
…ipynb Co-authored-by: Mathias Soeken <mathias.soeken@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated the sample notebooks to include examples of showing the time and space diagrams to visualize resource estimation results.