Revert "GVFSVerb: Use OAuth credentials by default" #1808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit abcb73f. Using this authentication mode by default is breaking some automated scenarios on build agents that use "gvfs clone". Removing the new default is a fast measure to fix these users, while a longer-term consideration for increasing adoption of OAuth can be done at a later date with the proper parties engaged.
vdye
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit cbd0cef. This commit was introduced in #1803 based on a comment I made recommending "faster adoption" but that was a mistake. When the release was shipped to
wingetyesterday, this led to breaks in some pipeline environments.Using this authentication mode by default is breaking some automated scenarios on build agents that use "gvfs clone". Removing the new default is a fast measure to fix these users, while a longer-term consideration for increasing adoption of OAuth can be done at a later date with the proper parties engaged.