Skip to content

Commit

Permalink
Updated spec (missing changes per previous API Review). Added contact…
Browse files Browse the repository at this point in the history
…s (added in WinAppSDK 1.1). Added PackageGraphRevisionId, for alignment with Windows API (GenerationId is soft-deprecated; will go away in a future release) (#2898)
  • Loading branch information
DrusTheAxe authored Oct 4, 2022
1 parent bbe7b8e commit 69f08e7
Showing 1 changed file with 23 additions and 7 deletions.
30 changes: 23 additions & 7 deletions specs/dynamicdependencies/DynamicDependencies.md
Original file line number Diff line number Diff line change
Expand Up @@ -1253,7 +1253,13 @@ STDAPI MddGetIdForPackageDependencyContext(
_In_ MDD_PACKAGEDEPENDENCY_CONTEXT packageDependencyContext,
_Outptr_result_maybenull_ PWSTR* packageDependencyId) noexcept;

/// Return the package graph's current generation id.
/// Return the package graph's current revision id.
STDAPI_(UINT32) MddGetPackageGraphRevisionId() noexcept;

/// Return the package graph's current revision id.
///
/// @note This API is deprecated and will be removed in a future release.
/// Use MddGetPackageGraphRevisionId().
STDAPI_(UINT32) MddGetGenerationId() noexcept;
```
Expand Down Expand Up @@ -1565,6 +1571,9 @@ namespace Microsoft.Windows.ApplicationModel.DynamicDependency
```c# (but really MIDL3)
namespace Microsoft.Windows.ApplicationModel.DynamicDependency
{
[contractversion(2)]
apicontract DynamicDependencyContract{};

/// CPU architectures to optionally filter available packages against a package dependency.
/// These generally correspond to processor architecture types supported by MSIX.
/// @see Windows.System.ProcessorArchitecture
Expand Down Expand Up @@ -1802,9 +1811,9 @@ runtimeclass PackageDependency
/// Calls to Add() can be balanced by a PackageDependencyContext.Remove()
/// to remove the entry from the package graph.
///
/// Successful calls change the package graph's current generation id.
/// Successful calls change the package graph's current revision id.
///
/// @see GenerationId
/// @see PackageGraphRevisionId
PackageDependencyContext Add();

/// Resolve a previously pinned PackageDependency to a specific package and
Expand Down Expand Up @@ -1841,12 +1850,19 @@ runtimeclass PackageDependency
/// Calls to Add() can be balanced by a PackageDependencyContext.Remove() (or object destruction)
/// to remove the entry from the package graph.
///
/// Successful calls change the package graph's current generation id.
/// Successful calls change the package graph's current revision id.
///
/// @see GenerationId
/// @see PackageGraphRevisionId
PackageDependencyContext Add(AddPackageDependencyOptions options);

/// Return the package graph's current generation id.
/// Return the package graph's current revision id.
[contract(DynamicDependencyContract, 2)]
static UInt32 PackageGraphRevisionId{ get; };

/// Return the package graph's current revision id.
///
/// @note This API is deprecated and will be removed in a future release.
/// Use the PackageGraphRevisionId property.
static UInt32 GenerationId{ get; };
};

Expand Down Expand Up @@ -1886,7 +1902,7 @@ runtimeclass PackageDependencyContext
///
/// Successful calls change the package graph's current revision id.
///
/// @see PackageDependency.GenerationId
/// @see PackageDependency.RevisionId
void Remove();
};
}
Expand Down

0 comments on commit 69f08e7

Please sign in to comment.