BREAKING CHANGE 0.9.5 release (#259)

* Update content for WER

* Update docs for XML.

* Update Copyright to 2017 :)

* fixes for #226, 227 and 228

* enable xml documentation generation (#232)

* enable xml documentation generation

* only generate xml documentation in release builds

* Update docs

* Filenames to StorageFiles

* Update README.md (#235)

Somebody decided to move all of the Hololens documentation and as a result pretty much every existing link on the internet is broken.  Fixing this one.

* Fixes a minor bug with xbox sample and cleans up StyleCop (#237)

* Add an IsFolder method to FileOrFolderInformation class.

* Updated per review feedback

* Adds PackageOrigin to PackageInfo class.

* PackageOrigin details and helper method

Quick helper method to determine if the app is sideloaded.

* Clean up some StyleCop errors.

* Restores our CSRF token handling (#238)

Addresses Issue #216

* Make underlying HTTP methods public so they can be called on a DevicePortal instance (#243)

* Prelim setup of namespaces

* Move HTTP Stream apis to public. Finish move of namespaces.

* Revert "Move HTTP Stream apis to public. Finish move of namespaces."

This reverts commit 2e715ff.

* Revert "Revert Namespaces changes in Master"

This reverts commit 871564eb18f525878063ca8cc4b0b9af2bb2ee79.

* Revert Namespaces changes in Master

* Finish Revert

* Setup files for internal CI server and NuGet package creation (#247)

* Create signConfig.xml

* Create DelaySign.extcomp

* Add DelaySign to NET

* Add DelaySign to UWP

* Testing INPATHROOT and full path for codesign

* Update signConfig.xml

* Update signConfig.xml

* Create WindowsDevicePortalWrapper.nuspec

* Changing to unsigned files

* Knowing my coworkers aliases

* Temp test for signing.

* Add StrongNameSigning.

* DelaySign

* New snk

* It's sourceS not source

* Update for XES Setup

* Authenticode Only

* .NET doesn't do sub directories ok

* Set nuspec relative to output

* Wrong folder for nuspec

* Copy also copies folders

* Update required fields in nuspec

* Correct names for signing

* Delete DelaySign.extcomp

* Removing extcomp

* Remove XEF delay sign

* Remove XEFDelay sign from net

* Fix blank version.

* Add TimeSpan field to Battery API results #161 (#250)

* Add IC server info for maintainers.

* fix field sizes in DeviceProcessInfo

* Fix SystemPerformanceInformation DataContract and add asserrt when websocket fails to parse data.

* Fix automated tests.

* Consolidate the assert on a deserialization failure to all rest requests and reduce duplicated logic.

* Fix spacing.

* Increase version number to 0.9.5.0. (#257)

* Make generic Stream REST APIs public as well. (#258)

CONTRIBUTING.md

@@ -80,6 +80,7 @@ When creating a new NuGet and GitHub release, the following steps should be take
 2. Merge from Master to Release, with a PR appropriately named ("v1.2.3 release")
 3. Squash and merge commits, leaving major feature entries and fixes in the description. 
 4. Compile release builds of the .NET and UWP libraries, sign them, and upload to NuGet 
+  a. We now have a CI server for this that builds, signs, and packages the NuGet package [here](https://microsoft.visualstudio.com/DefaultCollection/OS/_build/index?path=%5C&definitionId=14239).  
 5. Cut a new release on GitHub using the same version number ("v1.2.3") and attach the signed libraries to the release. 
 6. Update code documentation. 
 

WindowsDevicePortalWrapper/UnitTestProject/Core/PerformanceDataTests.cs

@@ -145,14 +145,14 @@ private static void ValidateRunningProcessesAsync(RunningProcesses runningProces
             Assert.AreEqual(systemIdleprocess.Name, "System Idle Process");
             Assert.IsNull(systemIdleprocess.PackageFullName);
             Assert.AreEqual(systemIdleprocess.PageFile, 0U);
-            Assert.AreEqual(systemIdleprocess.PrivateWorkingSet, 4096);
-            Assert.AreEqual(systemIdleprocess.ProcessId, 0);
+            Assert.AreEqual(systemIdleprocess.PrivateWorkingSet, 4096U);
+            Assert.AreEqual(systemIdleprocess.ProcessId, 0U);
             Assert.IsNull(systemIdleprocess.Publisher);
             Assert.AreEqual(systemIdleprocess.SessionId, 0U);
-            Assert.AreEqual(systemIdleprocess.TotalCommit, 0);
+            Assert.AreEqual(systemIdleprocess.TotalCommit, 0U);
             Assert.AreEqual(systemIdleprocess.UserName, "NT AUTHORITY\\SYSTEM");
             Assert.IsNull(systemIdleprocess.Version);
-            Assert.AreEqual(systemIdleprocess.VirtualSize, 65536);
+            Assert.AreEqual(systemIdleprocess.VirtualSize, 65536U);
             Assert.AreEqual(systemIdleprocess.WorkingSet, 4096U);
 
             DeviceProcessInfo devHomeProcess = processes[1];
@@ -163,14 +163,14 @@ private static void ValidateRunningProcessesAsync(RunningProcesses runningProces
             Assert.AreEqual(devHomeProcess.Name, "svchost.exe");
             Assert.IsNull(devHomeProcess.PackageFullName);
             Assert.AreEqual(devHomeProcess.PageFile, 5472256U);
-            Assert.AreEqual(devHomeProcess.PrivateWorkingSet, 4755456);
-            Assert.AreEqual(devHomeProcess.ProcessId, 892);
+            Assert.AreEqual(devHomeProcess.PrivateWorkingSet, 4755456U);
+            Assert.AreEqual(devHomeProcess.ProcessId, 892U);
             Assert.IsNull(devHomeProcess.Publisher);
             Assert.AreEqual(devHomeProcess.SessionId, 0U);
-            Assert.AreEqual(devHomeProcess.TotalCommit, 5914624);
+            Assert.AreEqual(devHomeProcess.TotalCommit, 5914624U);
             Assert.AreEqual(devHomeProcess.UserName, "NT AUTHORITY\\SYSTEM");
             Assert.IsNull(devHomeProcess.Version);
-            Assert.AreEqual(devHomeProcess.VirtualSize, 2203387539456);
+            Assert.AreEqual(devHomeProcess.VirtualSize, 2203387539456U);
             Assert.AreEqual(devHomeProcess.WorkingSet, 17285120U);
         }
 
@@ -181,18 +181,18 @@ private static void ValidateRunningProcessesAsync(RunningProcesses runningProces
         private static void ValidateSystemPerm(SystemPerformanceInformation systemPerfInfo)
         {
             // Check some known things about this response.
-            Assert.AreEqual(systemPerfInfo.AvailablePages, 369054);
-            Assert.AreEqual(systemPerfInfo.CommitLimit, 784851);
-            Assert.AreEqual(systemPerfInfo.CommittedPages, 322627);
-            Assert.AreEqual(systemPerfInfo.CpuLoad, 1);
-            Assert.AreEqual(systemPerfInfo.IoOtherSpeed, 3692);
-            Assert.AreEqual(systemPerfInfo.IoReadSpeed, 36);
-            Assert.AreEqual(systemPerfInfo.IoWriteSpeed, 6480);
-            Assert.AreEqual(systemPerfInfo.NonPagedPoolPages, 42504);
-            Assert.AreEqual(systemPerfInfo.PageSize, 4096);
-            Assert.AreEqual(systemPerfInfo.PagedPoolPages, 30697);
-            Assert.AreEqual(systemPerfInfo.TotalInstalledKb, 1048592);
-            Assert.AreEqual(systemPerfInfo.TotalPages, 655360);
+            Assert.AreEqual(systemPerfInfo.AvailablePages, 369054U);
+            Assert.AreEqual(systemPerfInfo.CommitLimit, 784851U);
+            Assert.AreEqual(systemPerfInfo.CommittedPages, 322627U);
+            Assert.AreEqual(systemPerfInfo.CpuLoad, 1U);
+            Assert.AreEqual(systemPerfInfo.IoOtherSpeed, 3692U);
+            Assert.AreEqual(systemPerfInfo.IoReadSpeed, 36U);
+            Assert.AreEqual(systemPerfInfo.IoWriteSpeed, 6480U);
+            Assert.AreEqual(systemPerfInfo.NonPagedPoolPages, 42504U);
+            Assert.AreEqual(systemPerfInfo.PageSize, 4096U);
+            Assert.AreEqual(systemPerfInfo.PagedPoolPages, 30697U);
+            Assert.AreEqual(systemPerfInfo.TotalInstalledKb, 1048592U);
+            Assert.AreEqual(systemPerfInfo.TotalPages, 655360U);
 
             Assert.AreEqual(systemPerfInfo.GpuData.Adapters.Count, 1);
             GpuAdapter gpuAdapter = systemPerfInfo.GpuData.Adapters[0];
@@ -204,11 +204,11 @@ private static void ValidateSystemPerm(SystemPerformanceInformation systemPerfIn
 
             Assert.AreEqual(gpuAdapter.EnginesUtilization.Count, 7);
             double enguineUtilization = gpuAdapter.EnginesUtilization[0];
-            Assert.AreEqual(enguineUtilization, 0.0011459999950602651);
+            Assert.AreEqual(enguineUtilization, 0.001146);
 
             NetworkPerformanceData networkPerformanceData = systemPerfInfo.NetworkData;
-            Assert.AreEqual(networkPerformanceData.BytesIn, 15000);
-            Assert.AreEqual(networkPerformanceData.BytesOut, 0);
+            Assert.AreEqual(networkPerformanceData.BytesIn, 15000U);
+            Assert.AreEqual(networkPerformanceData.BytesOut, 0U);
         }
     }
 }

WindowsDevicePortalWrapper/UnitTestProject/Device-VersionTests/HoloLens/HoloLensHelpers.cs

@@ -22,18 +22,18 @@ public static class HoloLensHelpers
         internal static void ValidateSystemPerfAsync(SystemPerformanceInformation systemPerfInfo)
         {
             // Check some known things about this response.
-            Assert.AreEqual(275897, systemPerfInfo.AvailablePages);
-            Assert.AreEqual(764290, systemPerfInfo.CommitLimit);
-            Assert.AreEqual(225486, systemPerfInfo.CommittedPages);
-            Assert.AreEqual(20, systemPerfInfo.CpuLoad);
-            Assert.AreEqual(4337544, systemPerfInfo.IoOtherSpeed);
-            Assert.AreEqual(1717438, systemPerfInfo.IoReadSpeed);
-            Assert.AreEqual(788621, systemPerfInfo.IoWriteSpeed);
-            Assert.AreEqual(15470, systemPerfInfo.NonPagedPoolPages);
-            Assert.AreEqual(4096, systemPerfInfo.PageSize);
-            Assert.AreEqual(18894, systemPerfInfo.PagedPoolPages);
-            Assert.AreEqual(2097152, systemPerfInfo.TotalInstalledKb);
-            Assert.AreEqual(502146, systemPerfInfo.TotalPages);
+            Assert.AreEqual(275897U, systemPerfInfo.AvailablePages);
+            Assert.AreEqual(764290U, systemPerfInfo.CommitLimit);
+            Assert.AreEqual(225486U, systemPerfInfo.CommittedPages);
+            Assert.AreEqual(20U, systemPerfInfo.CpuLoad);
+            Assert.AreEqual(4337544U, systemPerfInfo.IoOtherSpeed);
+            Assert.AreEqual(1717438U, systemPerfInfo.IoReadSpeed);
+            Assert.AreEqual(788621U, systemPerfInfo.IoWriteSpeed);
+            Assert.AreEqual(15470U, systemPerfInfo.NonPagedPoolPages);
+            Assert.AreEqual(4096U, systemPerfInfo.PageSize);
+            Assert.AreEqual(18894U, systemPerfInfo.PagedPoolPages);
+            Assert.AreEqual(2097152U, systemPerfInfo.TotalInstalledKb);
+            Assert.AreEqual(502146U, systemPerfInfo.TotalPages);
 
             Assert.AreEqual(systemPerfInfo.GpuData.Adapters.Count, 1);
             GpuAdapter gpuAdapter = systemPerfInfo.GpuData.Adapters[0];
@@ -47,8 +47,8 @@ internal static void ValidateSystemPerfAsync(SystemPerformanceInformation system
             Assert.AreEqual("7.098184", gpuAdapter.EnginesUtilization[0].ToString("n6"));
 
             NetworkPerformanceData networkPerformanceData = systemPerfInfo.NetworkData;
-            Assert.AreEqual(0, networkPerformanceData.BytesIn);
-            Assert.AreEqual(0, networkPerformanceData.BytesOut);
+            Assert.AreEqual(0U, networkPerformanceData.BytesIn);
+            Assert.AreEqual(0U, networkPerformanceData.BytesOut);
         }
 
         /// <summary>

WindowsDevicePortalWrapper/UnitTestProject/Device-VersionTests/XboxOne/XboxOne_rs1_xbox_rel_1608.cs

@@ -682,14 +682,14 @@ private static void ValidateRunningProcessesAsync(RunningProcesses runningProces
             Assert.AreEqual(systemIdleprocess.Name, "System Idle Process");
             Assert.IsNull(systemIdleprocess.PackageFullName);
             Assert.AreEqual(systemIdleprocess.PageFile, 0U);
-            Assert.AreEqual(systemIdleprocess.PrivateWorkingSet, 4096);
-            Assert.AreEqual(systemIdleprocess.ProcessId, 0);
+            Assert.AreEqual(systemIdleprocess.PrivateWorkingSet, 4096U);
+            Assert.AreEqual(systemIdleprocess.ProcessId, 0U);
             Assert.IsNull(systemIdleprocess.Publisher);
             Assert.AreEqual(systemIdleprocess.SessionId, 0U);
-            Assert.AreEqual(systemIdleprocess.TotalCommit, 0);
+            Assert.AreEqual(systemIdleprocess.TotalCommit, 0U);
             Assert.AreEqual(systemIdleprocess.UserName, "NT AUTHORITY\\SYSTEM");
             Assert.IsNull(systemIdleprocess.Version);
-            Assert.AreEqual(systemIdleprocess.VirtualSize, 65536);
+            Assert.AreEqual(systemIdleprocess.VirtualSize, 65536U);
             Assert.AreEqual(systemIdleprocess.WorkingSet, 4096U);
 
             DeviceProcessInfo devHomeProcess = processes[56];
@@ -700,18 +700,18 @@ private static void ValidateRunningProcessesAsync(RunningProcesses runningProces
             Assert.AreEqual(devHomeProcess.Name, "WWAHost.exe");
             Assert.AreEqual(devHomeProcess.PackageFullName, "Microsoft.Xbox.DevHome_100.1607.9000.0_x64__8wekyb3d8bbwe");
             Assert.AreEqual(devHomeProcess.PageFile, 47067136U);
-            Assert.AreEqual(devHomeProcess.PrivateWorkingSet, 32796672);
-            Assert.AreEqual(devHomeProcess.ProcessId, 3424);
+            Assert.AreEqual(devHomeProcess.PrivateWorkingSet, 32796672U);
+            Assert.AreEqual(devHomeProcess.ProcessId, 3424U);
             Assert.AreEqual(devHomeProcess.Publisher, "CN=Microsoft Corporation, O=Microsoft Corporation, L=Redmond, S=Washington, C=US");
             Assert.AreEqual(devHomeProcess.SessionId, 0U);
-            Assert.AreEqual(devHomeProcess.TotalCommit, 49213440);
+            Assert.AreEqual(devHomeProcess.TotalCommit, 49213440U);
 
             Assert.AreEqual(devHomeProcess.UserName, "TESTXBOX\\DefaultAccount");
             Assert.AreEqual(devHomeProcess.Version.Build, 9000U);
             Assert.AreEqual(devHomeProcess.Version.Major, 100U);
             Assert.AreEqual(devHomeProcess.Version.Minor, 1607U);
             Assert.AreEqual(devHomeProcess.Version.Revision, 0U);
-            Assert.AreEqual(devHomeProcess.VirtualSize, 2234032066560);
+            Assert.AreEqual(devHomeProcess.VirtualSize, 2234032066560U);
             Assert.AreEqual(devHomeProcess.WorkingSet, 79466496U);
         }
 
@@ -722,18 +722,18 @@ private static void ValidateRunningProcessesAsync(RunningProcesses runningProces
         private static void ValidateSystemPerm(SystemPerformanceInformation systemPerfInfo)
         {
             // Check some known things about this response.
-            Assert.AreEqual(systemPerfInfo.AvailablePages, 369054);
-            Assert.AreEqual(systemPerfInfo.CommitLimit, 784851);
-            Assert.AreEqual(systemPerfInfo.CommittedPages, 322627);
-            Assert.AreEqual(systemPerfInfo.CpuLoad, 1);
-            Assert.AreEqual(systemPerfInfo.IoOtherSpeed, 3692);
-            Assert.AreEqual(systemPerfInfo.IoReadSpeed, 36);
-            Assert.AreEqual(systemPerfInfo.IoWriteSpeed, 6480);
-            Assert.AreEqual(systemPerfInfo.NonPagedPoolPages, 42504);
-            Assert.AreEqual(systemPerfInfo.PageSize, 4096);
-            Assert.AreEqual(systemPerfInfo.PagedPoolPages, 30697);
-            Assert.AreEqual(systemPerfInfo.TotalInstalledKb, 1048592);
-            Assert.AreEqual(systemPerfInfo.TotalPages, 655360);
+            Assert.AreEqual(systemPerfInfo.AvailablePages, 369054U);
+            Assert.AreEqual(systemPerfInfo.CommitLimit, 784851U);
+            Assert.AreEqual(systemPerfInfo.CommittedPages, 322627U);
+            Assert.AreEqual(systemPerfInfo.CpuLoad, 1U);
+            Assert.AreEqual(systemPerfInfo.IoOtherSpeed, 3692U);
+            Assert.AreEqual(systemPerfInfo.IoReadSpeed, 36U);
+            Assert.AreEqual(systemPerfInfo.IoWriteSpeed, 6480U);
+            Assert.AreEqual(systemPerfInfo.NonPagedPoolPages, 42504U);
+            Assert.AreEqual(systemPerfInfo.PageSize, 4096U);
+            Assert.AreEqual(systemPerfInfo.PagedPoolPages, 30697U);
+            Assert.AreEqual(systemPerfInfo.TotalInstalledKb, 1048592U);
+            Assert.AreEqual(systemPerfInfo.TotalPages, 655360U);
 
             Assert.AreEqual(systemPerfInfo.GpuData.Adapters.Count, 1);
             GpuAdapter gpuAdapter = systemPerfInfo.GpuData.Adapters[0];
@@ -745,11 +745,11 @@ private static void ValidateSystemPerm(SystemPerformanceInformation systemPerfIn
 
             Assert.AreEqual(gpuAdapter.EnginesUtilization.Count, 7);
             double enguineUtilization = gpuAdapter.EnginesUtilization[0];
-            Assert.AreEqual(enguineUtilization, 0.0011459999950602651);
+            Assert.AreEqual(enguineUtilization, 0.001146);
 
             NetworkPerformanceData networkPerformanceData = systemPerfInfo.NetworkData;
-            Assert.AreEqual(networkPerformanceData.BytesIn, 15000);
-            Assert.AreEqual(networkPerformanceData.BytesOut, 0);
+            Assert.AreEqual(networkPerformanceData.BytesIn, 15000U);
+            Assert.AreEqual(networkPerformanceData.BytesOut, 0U);
         }
     }
 }

WindowsDevicePortalWrapper/Utilities/WindowsDevicePortalWrapper.nuspec

@@ -0,0 +1,30 @@
+<?xml version="1.0" encoding="utf-8"?>
+<package xmlns="http://schemas.microsoft.com/packaging/2011/08/nuspec.xsd">
+    <metadata>
+        <id>WindowsDevicePortalWrapper</id>
+        <version>0.0.0.0</version>
+        <title>Windows Device Portal Wrapper</title>
+        <authors>Windows Device Portal</authors>
+        <owners>Microsoft; Windows Device Portal</owners>
+        <licenseUrl>https://github.com/Microsoft/WindowsDevicePortalWrapper/blob/master/License.txt</licenseUrl>
+        <projectUrl>https://github.com/microsoft/windowsdeviceportalwrapper</projectUrl>
+        <requireLicenseAcceptance>false</requireLicenseAcceptance>
+        <description>The Device Portal Wrapper is a library that allows a client application to connect to a Device Portal instance on a Windows 10 device and call the REST APIs presented.  This allows an application to e.g. install apps, reboot the device, or get performance metrics.  
+
+See the GitHub repo at https://github.com/microsoft/windowsdeviceportalwrapper</description>
+        <summary>Remote control of Windows 10 device for developers and device labs.</summary>
+        <releaseNotes>[FILL IN BEFORE RELEASE]</releaseNotes>
+        <copyright>Microsoft Corp</copyright>
+        <language />
+        <tags>WDP Windows 10 Device Portal</tags>
+    </metadata>
+	<files>
+		<file src="WindowsDevicePortalWrapper.dll" target="lib\net452" />
+		<file src="release\AnyCPU\WindowsDevicePortalWrapper.pdb" target="lib\net452" />
+		<file src="release\AnyCPU\WindowsDevicePortalWrapper.xml" target="lib\net452" />
+
+		<file src="WindowsDevicePortalWrapper.UniversalWindows.dll" target="lib\uap10.0" />
+		<file src="release\AnyCPU\WindowsDevicePortalWrapper.UniversalWindows\WindowsDevicePortalWrapper.UniversalWindows.pdb" target="lib\uap10.0" />
+		<file src="release\AnyCPU\WindowsDevicePortalWrapper.UniversalWindows\WindowsDevicePortalWrapper.UniversalWindows.XML" target="lib\uap10.0" />
+    </files>
+</package>

WindowsDevicePortalWrapper/Utilities/signConfig.xml

@@ -0,0 +1,9 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<SignConfigXML>
+
+  <job platform="" configuration="Release" dest="" jobname="WDPW Sign" approvers="hirsin;aaronste">
+    <file src="__INPATHROOT__\WindowsDevicePortalWrapper.dll" signType="Authenticode" dest="__OUTPATHROOT__\WindowsDevicePortalWrapper.dll" />
+    <file src="__INPATHROOT__\WindowsDevicePortalWrapper.UniversalWindows\WindowsDevicePortalWrapper.UniversalWindows.dll" signType="Authenticode" dest="__OUTPATHROOT__\WindowsDevicePortalWrapper.UniversalWindows.dll" />
+  </job>
+
+</SignConfigXML>