[Port to release/1.50] Fix target platform when creating project from database via quickpick #26054
+72
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#26049) * Create project from quickpick * Fix test * Fix test
kburtram
approved these changes
Nov 13, 2024
|
@zijchen could you please resolve the merge conflict for this PR? Thanks! |
|
@kburtram it should be resolved now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26052
Porting #26049 and #26053
When creating a project from database via VS Code quickpick, the connection data is never passed to the controller, so it always defaulted to 160/Sql2022 target platform in the sqlproj. There used to be an option to create project from right clicking on a database in mssql, but it was removed at some point, making quickpick the only option. This PR fixes the code path via quickpick by passing the create project function as a callback.