Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings page is redesigned. #1984

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Settings page is redesigned. #1984

wants to merge 1 commit into from

Conversation

Zaryob
Copy link

@Zaryob Zaryob commented Mar 4, 2023

Its a kind of diss to Pull Request #1964 😄

Fixes #1963

And also problems that I see in #1964

Description of the changes:

  • As mentioned before, the content of the About section in the Settings tab was just sitting there. However, some changes were made in the aforementioned PR that I thought unnecessary. As a matter of fact, I think that the title and label values entered in Expander are incompatible with Windows style. (See the about output of the Photos Application
    image
    .)
  • For this reason, I made a change in accordance with the spirit of the Windows application as much as possible.
  • While doing this, unfortunately I had to add 2 new Resources. Although I entered these translations for en-us en-gb and tr-tr, I did not touch other translations. They also need to be translated.

How changes were validated:

Calculator.Dev.2023-03-04.23-36-21.mp4

I tested it manually on English and Turkish. But needs to look up Resources.resw files for each language and run unit tests.

Notes:

By the way, please don't be offended by the diss issue I joked about. After all, the source is open, everyone can interpret a view differently.

Its a kind of diss to Pull Request microsoft#1964 😄
@Zaryob
Copy link
Author

Zaryob commented Mar 4, 2023

@microsoft-github-policy-service agree

@Zaryob Zaryob closed this Sep 13, 2024
@Zaryob Zaryob reopened this Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using SettingsCard & SettingsExpander for the settings screen
1 participant