Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UnitConverterDataLoader.cpp #2033

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SahilDahat
Copy link

@SahilDahat SahilDahat commented Jul 28, 2023

Issue #2026

Fixes #.

Due to incorrect value of 44.7, result varied as given in the issue.

ViewMode::Speed, UnitConverterUnits::Speed_MilesPerHour, 44.7

The originally calculated value was different from actual (which should be)

ViewMode::Speed, UnitConverterUnits::Speed_MilesPerHour, 44.704

Description of the changes:

  • changed values of Speed_MilesPerHour

How changes were validated:

  • Tested the calculator app in my local machine & it does show that 1 miles per hour = 1.6092 Kilometers per hour
  • A quick google search shows that 1 mile per hour is 1.60934 kilometers per hour.
  • Changing to 44.704 resolves the issue.

Issue microsoft#2026 
Due to incorrect value of `ViewMode::Speed, UnitConverterUnits::Speed_MilesPerHour, 44.7`, calculated value was different from actual (which should be) `ViewMode::Speed, UnitConverterUnits::Speed_MilesPerHour, 44.704`.

Please correct me if I am wrong, this is my first contribution.
@SahilDahat
Copy link
Author

I am new to open source, please correct me if I am wrong, I would be really grateful! Thank you

@SahilDahat
Copy link
Author

Respected Devs,
I had opened this PR few days ago & would love to know if the changes made are correct. This is my first PR so please guide me a llittle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants