Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incorrect Russian graphing translations #2087

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BuiIdinger
Copy link

Fixes #.

#2052
#2053

Description of the changes:

  • Fixed Russian translations in graphing calculator
  • Corrected contribute text in settings

How changes were validated:

  • manual

@tian-lt tian-lt added the localization Updates to our localized strings label Jan 8, 2024
Copy link

@STeeL835 STeeL835 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some errors I haven't been able to check to see them in context (for example "deriv", I guess mentions of it exists in the codebase, but it wasn't actually implemented), but I mostly agree with the corrections

@@ -3567,7 +3567,7 @@
<comment>Error that occurs during graphing when a number has too many decimals. Ex: 1.2.3</comment>
</data>
<data name="DecimalPointWithoutDigits" xml:space="preserve">
<value>В десятичной запятой отсутствуют цифры</value>
<value>Нет цифр рядом с десятичной запятой</value>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe "Десятичная запятая не имеет цифр" would be more fitting to the language norms

<comment>Error that occurs during graphing when equal is used without an equation. Ex: sin(x=y)</comment>
</data>
<data name="ExpectParenthesisAfterFunctionName" xml:space="preserve">
<value>Скобки отсутствуют после имени функции</value>
<comment>Error that occurs during graphing when parenthesis are missing after a function.</comment>
</data>
<data name="IncorrectNumParameter" xml:space="preserve">
<value>Математическая операция имеет неверное количество параметров</value>
<value>Неверное количество параметров функции</value>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that this is a more fitting translation, but the original talks about operations too, so maybe it's used not only with functions?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is true, I surely overlooked this one.
This error can be triggered by trying to input y=log() in graphing mode for example. But entering y=x^ gives a different error (Непредвиденные символы в выражении). Логарифмирование is mathematical operation, however we can also say that logarithm is a function.
Maybe translation should be "Неверное количество параметров математической операции". Long, but covers all possible cases. Or just "Неверное количество параметров".

<comment>General error that occurs during graphing.</comment>
</data>
<data name="InvalidNumberDigit" xml:space="preserve">
<value>Цифра не может быть разрешена для данной базы</value>
<value>Цифра не может использоваться с этим основанием</value>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<value>Цифра не может использоваться с этим основанием</value>
<value>Не удалось определить цифру для заданного основания</value>

Though I haven't found how to trigger this error to see what it is about

@CaptainDno
Copy link

CaptainDno commented Apr 13, 2024

Thanks for all your corrections.
Sadly, the issue template for localization suggestion says that PRs with localization changes cannot be merged directly because files are generated by some internal system. However. it seems like this and other localizations PRs are not ignored. But I will post a comment to the original issue to make sure that this PR will not be overlooked.

We cannot _merge_ any suggested localization changes to our localized resources files. These files are automatically generated from an internal localization process. Any suggestion submitted this way will be duplicated into our internal localization system, and then closed here.

@CaptainDno
Copy link

Changes were merged in #2149.
Then some strings were edited again in #2181. I can't see any reason why Область определения was changed to more ambiguous Область, but in any case, I think this PR can be closed now. @BuiIdinger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization Updates to our localized strings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants